From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: f4bug@amsat.org, qemu-devel@nongnu.org, John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] AHCI: re-privatize ahci headers
Date: Fri, 23 Jun 2017 18:09:23 -0400 [thread overview]
Message-ID: <20170623220926.11479-1-jsnow@redhat.com> (raw)
As reported by Philippe Mathieu-Daudé, including AHCI headers can
quickly pull in more dependencies than is sane. To remedy this,
split the AHCI headers into public and private areas as best as we
can and move the private information back into hw/ide/.
The only code movement is performed in patch 2.
Patch 3 looks terrible, but all it is doing are two different moves,
renaming one include directive. If you have suggestions for doing
this diffstat differently, please advise.
John Snow (3):
ahci: add ahci_get_num_ports
ahci: Isolate public AHCI interface
ahci: split public and private interface
hw/i386/pc_q35.c | 4 +-
hw/ide/ahci.c | 10 +-
hw/ide/ahci_internal.h | 359 +++++++++++++++++++++++++++++++++++++++++++++++++
hw/ide/ich.c | 2 +-
hw/mips/boston.c | 4 +-
include/hw/ide/ahci.h | 320 +------------------------------------------
6 files changed, 376 insertions(+), 323 deletions(-)
create mode 100644 hw/ide/ahci_internal.h
--
2.9.4
next reply other threads:[~2017-06-23 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 22:09 John Snow [this message]
2017-06-23 22:09 ` [Qemu-devel] [PATCH 1/3] ahci: add ahci_get_num_ports John Snow
2017-06-26 4:37 ` Philippe Mathieu-Daudé
2017-06-23 22:09 ` [Qemu-devel] [PATCH 2/3] ahci: Isolate public AHCI interface John Snow
2017-06-26 4:34 ` Philippe Mathieu-Daudé
2017-06-23 22:09 ` [Qemu-devel] [PATCH 3/3] ahci: split public and private interface John Snow
2017-06-26 4:35 ` Philippe Mathieu-Daudé
2017-06-23 23:14 ` [Qemu-devel] [PATCH 0/3] AHCI: re-privatize ahci headers no-reply
2017-06-29 19:46 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623220926.11479-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).