From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPJtj-00007Y-4e for qemu-devel@nongnu.org; Sun, 25 Jun 2017 22:37:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPJtg-0000bZ-1k for qemu-devel@nongnu.org; Sun, 25 Jun 2017 22:37:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46346) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dPJtf-0000ZT-OO for qemu-devel@nongnu.org; Sun, 25 Jun 2017 22:37:03 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 244E98124A for ; Mon, 26 Jun 2017 02:37:01 +0000 (UTC) Date: Mon, 26 Jun 2017 10:36:56 +0800 From: Peter Xu Message-ID: <20170626023656.GE3936@pxdev.xzpeter.org> References: <1498193206-18007-1-git-send-email-peterx@redhat.com> <1498193206-18007-2-git-send-email-peterx@redhat.com> <20170623212432.GB10776@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170623212432.GB10776@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v5 01/10] machine: export register_compat_prop() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Laurent Vivier , Juan Quintela , "Dr . David Alan Gilbert" , Markus Armbruster On Fri, Jun 23, 2017 at 06:24:32PM -0300, Eduardo Habkost wrote: > On Fri, Jun 23, 2017 at 12:46:37PM +0800, Peter Xu wrote: > > We have HW_COMPAT_*, however that's only bound to machines, not other > > things (like accelerators). Behind it, it was register_compat_prop() > > that played the trick. Let's export the function for further use > > outside HW_COMPAT_* magic. > > > > Meanwhile, move it to qdev-properties.c where seems more proper (since > > it'll be used not only in machine codes). > > > > Signed-off-by: Peter Xu > > --- > > hw/core/machine.c | 13 ------------- > > hw/core/qdev-properties.c | 13 +++++++++++++ > > include/hw/qdev-properties.h | 3 +++ > > 3 files changed, 16 insertions(+), 13 deletions(-) > > > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > index 2e7e977..ecb5552 100644 > > --- a/hw/core/machine.c > > +++ b/hw/core/machine.c > > @@ -770,19 +770,6 @@ static void machine_class_finalize(ObjectClass *klass, void *data) > > g_free(mc->name); > > } > > > > -static void register_compat_prop(const char *driver, > > - const char *property, > > - const char *value) > > -{ > > - GlobalProperty *p = g_new0(GlobalProperty, 1); > > - /* Machine compat_props must never cause errors: */ > > - p->errp = &error_abort; > > - p->driver = driver; > > - p->property = property; > > - p->value = value; > > - qdev_prop_register_global(p); > > -} > > - > > static void machine_register_compat_for_subclass(ObjectClass *oc, void *opaque) > > { > > GlobalProperty *p = opaque; > > diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c > > index 9f1a497..6ff1ac3 100644 > > --- a/hw/core/qdev-properties.c > > +++ b/hw/core/qdev-properties.c > > @@ -1047,6 +1047,19 @@ void qdev_prop_register_global(GlobalProperty *prop) > > global_props = g_list_append(global_props, prop); > > } > > > > +void register_compat_prop(const char *driver, > > + const char *property, > > + const char *value) > > +{ > > + GlobalProperty *p = g_new0(GlobalProperty, 1); > > + /* Machine compat_props must never cause errors: */ > > Now this won't be used only for machine compat_props, so this comment > needs to be deleted or updated (see suggestion below). Yes. Fixing. > > > > + p->errp = &error_abort; > > + p->driver = driver; > > + p->property = property; > > + p->value = value; > > + qdev_prop_register_global(p); > > +} > > + > > void qdev_prop_register_global_list(GlobalProperty *props) > > { > > int i; > > diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h > > index d206fc9..1722ca4 100644 > > --- a/include/hw/qdev-properties.h > > +++ b/include/hw/qdev-properties.h > > @@ -201,6 +201,9 @@ void qdev_prop_set_globals(DeviceState *dev); > > void error_set_from_qdev_prop_error(Error **errp, int ret, DeviceState *dev, > > Property *prop, const char *value); > > > > As this function is very easy to be misused, I suggest including the > following documentation: > > /** > * register_compat_prop: > * > * Register internal (not user-provided) global property, changing the > * default value of a given property in a device type. This can be used > * for enabling machine-type compatibility or for enabling > * accelerator-specific defaults in devices. > * > * The property values set using this function must be always valid and > * never report setter errors, as they property have > * GlobalProperty::errp set to &error_abort. > * > * User-provided global properties should override internal global > * properties, so callers of this function should ensure that it is > * called before user-provided global properties are registered. > * > * @driver: Device type to be affected > * @property: Property whose default value is going to be changed > * @value: New default value for the property > */ Sure. Will take it directly. Thanks! > > > +void register_compat_prop(const char *driver, const char *property, > > + const char *value); > > + > > /** > > * qdev_property_add_static: > > * @dev: Device to add the property to. > > -- > > 2.7.4 > > > > > > -- > Eduardo -- Peter Xu