From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Emilio G. Cota" <cota@braap.org>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v8 7/7] trace: [trivial] Statically enable all guest events
Date: Mon, 26 Jun 2017 10:26:21 +0100 [thread overview]
Message-ID: <20170626092621.GB495@redhat.com> (raw)
In-Reply-To: <87d19rf6p5.fsf@frigg.lan>
On Mon, Jun 26, 2017 at 12:18:14PM +0300, Lluís Vilanova wrote:
> Daniel P Berrange writes:
>
> > On Thu, Jun 08, 2017 at 10:25:22PM -0400, Emilio G. Cota wrote:
> >> From: Lluís Vilanova <vilanova@ac.upc.edu>
> >>
> >> The optimizations of this series makes it feasible to have them
> >> available on all builds.
>
> > I'm not saying you're wrong, but where is the data to backup this
> > assertion ?
>
> > IMHO, this commit message should be describing how performance was
> > tested and what the results were.
>
> I can submit a new series with the performance measurements now that you've
> informally OK'ed Emilio's new patch.
>
> Is there some public script to automate that or do I have to cook my own?
I don't think there's anything standardized in this area.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-06-26 9:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 2:25 [Qemu-devel] [PATCH v8 0/7] trace: [tcg] Optimize per-vCPU tracing states Emilio G. Cota
2017-06-09 2:25 ` [Qemu-devel] [PATCH v8 1/7] exec: [tcg] Refactor flush of per-CPU virtual TB cache Emilio G. Cota
2017-06-09 2:25 ` [Qemu-devel] [PATCH v8 2/7] cpu: allocate cpu->trace_dstate in place Emilio G. Cota
2017-06-11 12:36 ` Lluís Vilanova
2017-06-25 9:41 ` Lluís Vilanova
2017-06-26 8:26 ` Daniel P. Berrange
2017-06-09 2:25 ` [Qemu-devel] [PATCH v8 3/7] trace: [tcg] Delay changes to dynamic state when translating Emilio G. Cota
2017-06-09 2:25 ` [Qemu-devel] [PATCH v8 4/7] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state Emilio G. Cota
2017-06-09 2:25 ` [Qemu-devel] [PATCH v8 5/7] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events Emilio G. Cota
2017-06-09 2:25 ` [Qemu-devel] [PATCH v8 6/7] trace: [tcg, trivial] Re-align generated code Emilio G. Cota
2017-06-09 2:25 ` [Qemu-devel] [PATCH v8 7/7] trace: [trivial] Statically enable all guest events Emilio G. Cota
2017-06-26 8:28 ` Daniel P. Berrange
2017-06-26 9:18 ` Lluís Vilanova
2017-06-26 9:26 ` Daniel P. Berrange [this message]
2017-06-26 9:32 ` Laurent Desnogues
2017-06-26 16:22 ` Lluís Vilanova
2017-06-26 16:26 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626092621.GB495@redhat.com \
--to=berrange@redhat.com \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).