From: Stefan Hajnoczi <stefanha@gmail.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>
Cc: qemu-devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 3/8] block: add throttle block filter driver
Date: Mon, 26 Jun 2017 15:34:28 +0100 [thread overview]
Message-ID: <20170626143428.GD29664@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170623124700.1389-4-el13635@mail.ntua.gr>
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
On Fri, Jun 23, 2017 at 03:46:55PM +0300, Manos Pitsidianakis wrote:
> + qemu_co_queue_init(&tgm->throttled_reqs[0]);
> + qemu_co_queue_init(&tgm->throttled_reqs[1]);
Where is reqs_lock initialized?
It would be cleaner to move the throttled_reqs[] and reqs_lock
initialization into the tgm registration function. That way it's done
in a single place.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-06-26 14:34 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 12:46 [Qemu-devel] [PATCH RFC v3 0/8] I/O Throtting block filter driver Manos Pitsidianakis
2017-06-23 12:46 ` [Qemu-devel] [PATCH RFC v3 1/8] block: move ThrottleGroup membership to ThrottleGroupMember Manos Pitsidianakis
2017-06-26 13:23 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-06-27 12:08 ` [Qemu-devel] " Alberto Garcia
2017-06-27 12:24 ` Manos Pitsidianakis
2017-06-23 12:46 ` [Qemu-devel] [PATCH RFC v3 2/8] block: Add aio_context field in ThrottleGroupMember Manos Pitsidianakis
2017-06-26 13:36 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-06-26 14:03 ` Manos Pitsidianakis
2017-06-27 12:39 ` [Qemu-devel] " Alberto Garcia
2017-06-28 11:27 ` Kevin Wolf
2017-06-28 12:15 ` Manos Pitsidianakis
2017-06-28 12:44 ` Kevin Wolf
2017-06-23 12:46 ` [Qemu-devel] [PATCH RFC v3 3/8] block: add throttle block filter driver Manos Pitsidianakis
2017-06-26 14:00 ` [Qemu-devel] [Qemu-block] " Manos Pitsidianakis
2017-06-26 14:30 ` Stefan Hajnoczi
2017-06-26 16:01 ` Manos Pitsidianakis
2017-06-27 12:42 ` Stefan Hajnoczi
2017-06-26 16:26 ` Manos Pitsidianakis
2017-06-27 12:45 ` Stefan Hajnoczi
2017-06-27 13:34 ` Manos Pitsidianakis
2017-06-28 12:11 ` Stefan Hajnoczi
2017-06-26 14:34 ` Stefan Hajnoczi [this message]
2017-06-28 14:40 ` [Qemu-devel] " Kevin Wolf
2017-06-28 15:22 ` Manos Pitsidianakis
2017-06-28 15:36 ` Kevin Wolf
2017-06-28 15:50 ` Manos Pitsidianakis
2017-06-23 12:46 ` [Qemu-devel] [PATCH RFC v3 4/8] block: convert ThrottleGroup to object with QOM Manos Pitsidianakis
2017-06-26 14:52 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-06-26 15:24 ` Manos Pitsidianakis
2017-06-27 12:57 ` Stefan Hajnoczi
2017-06-26 16:58 ` Manos Pitsidianakis
2017-06-27 13:02 ` Stefan Hajnoczi
2017-06-27 16:05 ` Alberto Garcia
2017-06-27 16:12 ` Manos Pitsidianakis
2017-06-28 12:07 ` Stefan Hajnoczi
2017-06-23 12:46 ` [Qemu-devel] [PATCH RFC v3 5/8] block: add BlockDevOptionsThrottle to QAPI Manos Pitsidianakis
2017-06-26 14:55 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-06-27 13:12 ` [Qemu-devel] " Eric Blake
2017-06-28 13:35 ` Alberto Garcia
2017-06-28 13:42 ` Manos Pitsidianakis
2017-06-28 15:50 ` Kevin Wolf
2017-06-28 16:02 ` Eric Blake
2017-06-28 16:18 ` Kevin Wolf
2017-06-23 12:46 ` [Qemu-devel] [PATCH RFC v3 6/8] block: add options parameter to bdrv_new_open_driver() Manos Pitsidianakis
2017-06-26 15:11 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-06-28 15:55 ` Kevin Wolf
2017-06-28 13:42 ` [Qemu-devel] " Alberto Garcia
2017-06-28 13:47 ` Manos Pitsidianakis
2017-06-23 12:46 ` [Qemu-devel] [PATCH RFC v3 7/8] block: remove legacy I/O throttling Manos Pitsidianakis
2017-06-26 15:44 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-06-26 22:45 ` Manos Pitsidianakis
2017-06-27 13:08 ` Stefan Hajnoczi
2017-06-23 12:47 ` [Qemu-devel] [PATCH RFC v3 8/8] block: add throttle block filter driver interface tests Manos Pitsidianakis
2017-06-28 11:18 ` Kevin Wolf
2017-06-26 15:46 ` [Qemu-devel] [Qemu-block] [PATCH RFC v3 0/8] I/O Throtting block filter driver Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626143428.GD29664@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).