Re: [Qemu-devel] [PATCH v8 7/7] trace: [trivial] Statically enable all guest events

["Daniel P. Berrange" <berrange@redhat.com>]

On Mon, Jun 26, 2017 at 07:22:28PM +0300, Lluís Vilanova wrote:
> Lluís Vilanova writes:
> 
> > Daniel P Berrange writes:
> >> On Thu, Jun 08, 2017 at 10:25:22PM -0400, Emilio G. Cota wrote:
> >>> From: Lluís Vilanova <vilanova@ac.upc.edu>
> >>> 
> >>> The optimizations of this series makes it feasible to have them
> >>> available on all builds.
> 
> >> I'm not saying you're wrong, but where is the data to backup this
> >> assertion ?
> 
> >> IMHO, this commit message should be describing how performance was
> >> tested and what the results were.
> 
> > I can submit a new series with the performance measurements now that you've
> > informally OK'ed Emilio's new patch.
> 
> > Is there some public script to automate that or do I have to cook my own?
> 
> BTW, I just realized that my original cover for v7 did include results:
> 
>   https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg02741.html
> 
> Do such numbers need to be in this commit or is the cover fine?

Please do copy that info to the commit message - when someone looks back
at git history in a year's time, they'll have the commit message right
there, but will rarely think to look through the mailing list for a cover
letter with data.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|