From: "Daniel P. Berrange" <berrange@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, alistair23@gmail.com
Subject: Re: [Qemu-devel] [RFC v1 0/3] Implement a warning_report function
Date: Wed, 28 Jun 2017 10:07:46 +0100 [thread overview]
Message-ID: <20170628090746.GF29134@redhat.com> (raw)
In-Reply-To: <cover.1498596157.git.alistair.francis@xilinx.com>
On Tue, Jun 27, 2017 at 01:45:41PM -0700, Alistair Francis wrote:
> QEMU currently has a standard method to report errors with
> error_repot(). This ensure a sane and standard format when printing
> errors. This series is attempting to add the same functionality for
> warnings.
I'm not seeing the obvious benefit in this change. Despite its name
'error_report' is ultimately just a clever way to run printf()
on a text string. It can be used for errors, warnings, information
alike. If anything the current method is simply misnamed, and could
be changed to 'message_report'.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-06-28 9:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 20:45 [Qemu-devel] [RFC v1 0/3] Implement a warning_report function Alistair Francis
2017-06-27 20:45 ` [Qemu-devel] [RFC v1 1/3] util/qemu-error: Rename error_print_loc() to be more generic Alistair Francis
2017-06-28 4:32 ` Philippe Mathieu-Daudé
2017-06-27 20:45 ` [Qemu-devel] [RFC v1 2/3] util/qemu-error: Add a warning_report() function Alistair Francis
2017-06-27 22:21 ` Thomas Huth
2017-06-28 0:16 ` Alistair Francis
2017-06-28 9:04 ` Daniel P. Berrange
2017-06-28 16:16 ` Alistair Francis
2017-06-28 16:19 ` Daniel P. Berrange
2017-06-29 7:38 ` Markus Armbruster
2017-06-27 20:45 ` [Qemu-devel] [RFC v1 3/3] char-socket: Report TCP socket waiting as a warning Alistair Francis
2017-06-27 21:10 ` Edgar E. Iglesias
2017-06-28 0:17 ` Alistair Francis
2017-06-28 6:15 ` Edgar E. Iglesias
2017-06-28 16:18 ` Alistair Francis
2017-06-28 9:07 ` Daniel P. Berrange [this message]
2017-06-28 15:49 ` [Qemu-devel] [RFC v1 0/3] Implement a warning_report function Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628090746.GF29134@redhat.com \
--to=berrange@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).