From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, Pavel Butsykin <pbutsykin@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function
Date: Wed, 28 Jun 2017 14:57:04 +0200 [thread overview]
Message-ID: <20170628125704.GF5378@noname.redhat.com> (raw)
In-Reply-To: <b1a33e94-b32b-c6ca-c526-6dbb201a25b1@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
Am 27.06.2017 um 13:40 hat Eric Blake geschrieben:
> On 06/15/2017 11:38 AM, Stefan Hajnoczi wrote:
> > Avoid duplicating the QEMU command-line.
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > tests/qemu-iotests/068 | 13 ++++++++-----
> > 1 file changed, 8 insertions(+), 5 deletions(-)
> >
>
> > +# Give qemu some time to boot before saving the VM state
> > +bash -c 'sleep 1; echo -e "savevm 0\nquit"' | _qemu
>
> Are we sure that 'bash' on PATH is the same as the /bin/bash running the
> script?
Do we even need to explicitly call bash here? Doesn't this do the same
as far as this test case is concerned?
( sleep 1; echo "..." ) | _qemu
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2017-06-28 12:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 16:38 [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!) Stefan Hajnoczi
2017-06-15 16:38 ` [Qemu-devel] [PATCH 1/5] virtio-pci: use ioeventfd even when KVM is disabled Stefan Hajnoczi
2017-06-16 3:26 ` Michael S. Tsirkin
2017-06-16 9:13 ` Stefan Hajnoczi
2017-06-16 14:12 ` Michael S. Tsirkin
2017-06-19 12:23 ` Stefan Hajnoczi
2017-06-27 8:43 ` Fam Zheng
2017-06-27 11:07 ` Kevin Wolf
2017-06-28 12:17 ` Stefan Hajnoczi
2017-06-15 16:38 ` [Qemu-devel] [PATCH 2/5] migration: hold AioContext lock for loadvm qemu_fclose() Stefan Hajnoczi
2017-06-15 16:38 ` [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function Stefan Hajnoczi
2017-06-19 12:47 ` Kevin Wolf
2017-06-27 11:40 ` Eric Blake
2017-06-27 11:42 ` Eric Blake
2017-06-28 12:13 ` Stefan Hajnoczi
2017-06-28 12:50 ` Eric Blake
2017-06-28 12:57 ` Kevin Wolf [this message]
2017-06-28 14:02 ` Eric Blake
2017-06-28 14:07 ` Kevin Wolf
2017-06-15 16:38 ` [Qemu-devel] [PATCH 4/5] qemu-iotests: 068: use -drive/-device instead of -hda Stefan Hajnoczi
2017-06-15 16:38 ` [Qemu-devel] [PATCH 5/5] qemu-iotests: 068: test iothread mode Stefan Hajnoczi
2017-06-15 16:42 ` [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!) Stefan Hajnoczi
2017-06-19 12:26 ` Pavel Butsykin
2017-07-05 12:55 ` Stefan Hajnoczi
2017-07-05 14:04 ` Pavel Butsykin
2017-06-19 12:55 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628125704.GF5378@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=pbutsykin@virtuozzo.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).