From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQH2l-0006if-5w for qemu-devel@nongnu.org; Wed, 28 Jun 2017 13:46:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQH2g-0006r5-AI for qemu-devel@nongnu.org; Wed, 28 Jun 2017 13:46:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51482) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dQH2g-0006qh-3m for qemu-devel@nongnu.org; Wed, 28 Jun 2017 13:46:18 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E655681226 for ; Wed, 28 Jun 2017 17:46:16 +0000 (UTC) Date: Wed, 28 Jun 2017 14:46:15 -0300 From: Eduardo Habkost Message-ID: <20170628174615.GH12152@localhost.localdomain> References: <1498536619-14548-1-git-send-email-peterx@redhat.com> <1498536619-14548-7-git-send-email-peterx@redhat.com> <9f1a393d-9cef-e18a-3336-91ded86f6afa@redhat.com> <20170627133644.GW12152@localhost.localdomain> <20170628065434.GF14652@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170628065434.GF14652@pxdev.xzpeter.org> Subject: Re: [Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: Eric Blake , qemu-devel@nongnu.org, Laurent Vivier , Markus Armbruster , Juan Quintela , "Dr . David Alan Gilbert" On Wed, Jun 28, 2017 at 02:54:34PM +0800, Peter Xu wrote: > On Tue, Jun 27, 2017 at 10:36:44AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 27, 2017 at 06:15:37AM -0500, Eric Blake wrote: > > > On 06/26/2017 11:10 PM, Peter Xu wrote: > > > > One less global variable, and it does only matter with migration. > > > > > > > > We keep the old "--only-migratable" option, but also now we support: > > > > > > > > -global migration.only-migratable=true > > > > > > Does command line introspection work to see that this new spelling is > > > available? If not, what else can we do to let libvirt learn that the > > > new form is preferred? > > > > "only-migratable" will appear on the output of > > "device-list-properties typename=migration". But although I think > > implementing this using global properties internally is nice, I'm unsure > > about making -global the recommended interface to configure this. > > Could I ask why it may not good to use "-global" to configure it? > > Actually if we can merge this series, there is planned work to expose > more migration parameters to the user, like: migration.postcopy, > migration.compression, migration.speed, etc. So before I post similar > patches like this to export more things, I would like to know whether > there is possible issue with it in general. Thanks, I don't see any obvious issue with "-global migration.FOO=BAR", but I just want to be 100% sure before making it the recommended interface to configure migration options. If there are no objections, I'm OK with that. -- Eduardo