qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 6/6] virtio-pci: use ioeventfd even when KVM is disabled
Date: Wed, 28 Jun 2017 19:47:24 +0100	[thread overview]
Message-ID: <20170628184724.21378-7-stefanha@redhat.com> (raw)
In-Reply-To: <20170628184724.21378-1-stefanha@redhat.com>

Old kvm.ko versions only supported a tiny number of ioeventfds so
virtio-pci avoids ioeventfds when kvm_has_many_ioeventfds() returns 0.

Do not check kvm_has_many_ioeventfds() when KVM is disabled since it
always returns 0.  Since commit 8c56c1a592b5092d91da8d8943c17777d6462a6f
("memory: emulate ioeventfd") it has been possible to use ioeventfds in
qtest or TCG mode.

This patch makes -device virtio-blk-pci,iothread=iothread0 work even
when KVM is disabled.

I have tested that virtio-blk-pci works under TCG both with and without
iothread.

This patch fixes qemu-iotests 068, which was accidentally merged early
despite the dependency on ioeventfd.

Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-id: 20170615163813.7255-2-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/virtio/virtio-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 20d6a08..301920e 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -1740,7 +1740,7 @@ static void virtio_pci_realize(PCIDevice *pci_dev, Error **errp)
     bool pcie_port = pci_bus_is_express(pci_dev->bus) &&
                      !pci_bus_is_root(pci_dev->bus);
 
-    if (!kvm_has_many_ioeventfds()) {
+    if (kvm_enabled() && !kvm_has_many_ioeventfds()) {
         proxy->flags &= ~VIRTIO_PCI_FLAG_USE_IOEVENTFD;
     }
 
-- 
2.9.4

  parent reply	other threads:[~2017-06-28 18:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 18:47 [Qemu-devel] [PATCH 0/6] virtio: use ioeventfd in TCG and qtest mode Stefan Hajnoczi
2017-06-28 18:47 ` [Qemu-devel] [PATCH 1/6] libqos: fix typo in virtio.h QVirtQueue->used comment Stefan Hajnoczi
2017-06-29  8:32   ` Fam Zheng
2017-06-28 18:47 ` [Qemu-devel] [PATCH 2/6] libqos: add virtio used ring support Stefan Hajnoczi
2017-06-29  8:39   ` Fam Zheng
2017-06-28 18:47 ` [Qemu-devel] [PATCH 3/6] tests: fix virtio-scsi-test ISR dependence Stefan Hajnoczi
2017-06-29  8:40   ` Fam Zheng
2017-06-28 18:47 ` [Qemu-devel] [PATCH 4/6] tests: fix virtio-blk-test " Stefan Hajnoczi
2017-06-29  8:55   ` Fam Zheng
2017-06-28 18:47 ` [Qemu-devel] [PATCH 5/6] tests: fix virtio-net-test " Stefan Hajnoczi
2017-06-29  8:56   ` Fam Zheng
2017-06-28 18:47 ` Stefan Hajnoczi [this message]
2017-06-29  8:57   ` [Qemu-devel] [PATCH 6/6] virtio-pci: use ioeventfd even when KVM is disabled Fam Zheng
2017-06-28 19:38 ` [Qemu-devel] [PATCH 0/6] virtio: use ioeventfd in TCG and qtest mode Eric Blake
2017-06-29  9:47   ` Kevin Wolf
2017-06-29 23:34 ` Michael S. Tsirkin
2017-06-30 10:27 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170628184724.21378-7-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).