From: "Emilio G. Cota" <cota@braap.org>
To: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 0/7] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches
Date: Wed, 28 Jun 2017 19:07:25 -0400 [thread overview]
Message-ID: <20170628230725.GA9893@flamenco> (raw)
In-Reply-To: <878tkce4sm.fsf@frigg.lan>
On Wed, Jun 28, 2017 at 14:21:29 +0300, Lluís Vilanova wrote:
> Emilio G Cota writes:
> > I wanted to save you some time and sent a v9 yesterday with these
> > same changes -- although I see some changes in my v8 didn't make it
> > to your v9. For this iteration I only added more perf numbers to the
> > last patch, see here:
> > https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg05764.html
>
> Woops, sorry about the duplicate effort.
>
> I just dropped the rename of variable trace_ds, since I prefer names whose
> purpose can be more easily understood.
- I think trace_vcpu_dstate is way too long (IMO a short name + a comment
in the struct is better).
- You missed a change I made to patch 3:
> [cota: use CPU_TRACE_DSTATE_MAX_EVENTS instead of trace_get_vcpu_event_count()]
Was that intentional?
- Would be nice to include the perf numbers I got, along with yours.
E.
next prev parent reply other threads:[~2017-06-28 23:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 9:52 [Qemu-devel] [PATCH v9 0/7] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches Lluís Vilanova
2017-06-27 9:56 ` [Qemu-devel] [PATCH v9 1/7] exec: [tcg] Refactor flush of per-CPU virtual TB cache Lluís Vilanova
2017-06-27 10:00 ` [Qemu-devel] [PATCH v9 2/7] trace: Allocate cpu->trace_dstate in place Lluís Vilanova
2017-06-27 10:04 ` [Qemu-devel] [PATCH v9 3/7] trace: [tcg] Delay changes to dynamic state when translating Lluís Vilanova
2017-06-27 10:08 ` [Qemu-devel] [PATCH v9 4/7] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state Lluís Vilanova
2017-06-27 10:12 ` [Qemu-devel] [PATCH v9 5/7] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events Lluís Vilanova
2017-06-27 10:16 ` [Qemu-devel] [PATCH v9 6/7] trace: [tcg, trivial] Re-align generated code Lluís Vilanova
2017-06-27 10:20 ` [Qemu-devel] [PATCH v9 7/7] trace: [trivial] Statically enable all guest events Lluís Vilanova
2017-06-27 17:58 ` [Qemu-devel] [PATCH v9 0/7] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches Emilio G. Cota
2017-06-28 11:21 ` Lluís Vilanova
2017-06-28 23:07 ` Emilio G. Cota [this message]
2017-06-29 6:35 ` Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628230725.GA9893@flamenco \
--to=cota@braap.org \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).