qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Emilio G . Cota" <cota@braap.org>,
	"Stefan Weil" <sw@weilnetz.de>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64
Date: Wed, 28 Jun 2017 22:02:57 -0300	[thread overview]
Message-ID: <20170629010300.2848-6-f4bug@amsat.org> (raw)
In-Reply-To: <20170629010300.2848-1-f4bug@amsat.org>

remove some copy/paste leftover, code seems sane.

while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img:

Trace 0x7fa1904b0890 [0: ffffffc00036cd04]
----------------
IN:
0xffffffc00036cd24:  5ac00694      rev16 w20, w20

OP:
 ---- ffffffc00036cd24 0000000000000000 0000000000000000
 ext32u_i64 tmp3,x20
 ext16u_i64 tmp2,tmp3
 bswap16_i64 x20,tmp2
 movi_i64 tmp4,$0x10
 shr_i64 tmp2,tmp3,tmp4
 ext16u_i64 tmp2,tmp2
 bswap16_i64 tmp2,tmp2
 deposit_i64 x20,x20,tmp2,$0x10,$0x10

Linking TBs 0x7fa1904b0890 [ffffffc00036cd04] index 0 -> 0x7fa1904b0aa0 [ffffffc00036cd24]
Trace 0x7fa1904b0aa0 [0: ffffffc00036cd24]
TODO qemu/tci.c:1049: tcg_qemu_tb_exec()
qemu/tci.c:1049: tcg fatal error
Aborted

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 tcg/tci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tcg/tci.c b/tcg/tci.c
index 4bdc645f2a..f39bfb95c0 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -1046,7 +1046,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
             break;
 #if TCG_TARGET_HAS_bswap16_i64
         case INDEX_op_bswap16_i64:
-            TODO();
             t0 = *tb_ptr++;
             t1 = tci_read_r16(&tb_ptr);
             tci_write_reg64(t0, bswap16(t1));
-- 
2.13.1

  parent reply	other threads:[~2017-06-29  1:03 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29  1:02 [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter) Philippe Mathieu-Daudé
2017-06-29  1:02 ` [Qemu-devel] [PATCH 1/8] MAINTAINERS: update TCG entries Philippe Mathieu-Daudé
2017-06-29  1:02 ` [Qemu-devel] [PATCH 2/8] MAINTAINERS: update KVM entries Philippe Mathieu-Daudé
2017-06-29  1:02 ` [Qemu-devel] [PATCH 3/8] MAINTAINERS: update Xen entry Philippe Mathieu-Daudé
2017-06-29 10:39   ` Anthony PERARD
2017-06-29 11:54     ` Philippe Mathieu-Daudé
2017-06-29 11:47   ` Paolo Bonzini
2017-06-29  1:02 ` [Qemu-devel] [PATCH 4/8] MAINTAINERS: update TCI entry Philippe Mathieu-Daudé
2017-06-29  1:02 ` Philippe Mathieu-Daudé [this message]
2017-06-29 16:29   ` [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64 Eric Blake
2017-06-29 16:41     ` Philippe Mathieu-Daudé
2017-06-29 16:52     ` Stefan Weil
2017-06-29 17:02       ` Philippe Mathieu-Daudé
2017-06-29  1:02 ` [Qemu-devel] [PATCH 6/8] tcg/tci: disable MTTCG if TCI is enabled Philippe Mathieu-Daudé
2017-07-26  1:28   ` Philippe Mathieu-Daudé
2017-07-26  8:02     ` Alex Bennée
2017-08-03 17:40       ` Philippe Mathieu-Daudé
2017-08-03 17:56         ` Richard Henderson
2017-08-03 18:04           ` Philippe Mathieu-Daudé
2017-06-29  1:02 ` [Qemu-devel] [RFC PATCH 7/8] tcg/tci: time to remove it :( Philippe Mathieu-Daudé
2017-06-29  8:36   ` Daniel P. Berrange
2017-06-29  1:03 ` [Qemu-devel] [RFC PATCH 8/8] travis: remove tcg/tci job Philippe Mathieu-Daudé
2017-06-29  8:46 ` [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter) Thomas Huth
2017-06-29 14:57   ` Philippe Mathieu-Daudé
2017-06-29 15:06   ` Paolo Bonzini
2017-06-29 15:46     ` Thomas Huth
2017-06-29 15:47       ` Paolo Bonzini
2017-06-29 16:02         ` Thomas Huth
2017-06-29 16:18         ` Philippe Mathieu-Daudé
2017-06-29 16:45         ` Stefan Weil
2017-06-29 16:59           ` Peter Maydell
2017-06-29 16:07       ` Daniel P. Berrange
2017-06-29 16:13         ` Peter Maydell
2017-06-29 16:17         ` Thomas Huth
2017-06-29 18:09 ` Stefan Weil
2017-06-30  9:24   ` Peter Maydell
2017-07-06 23:49 ` no-reply
2017-07-07  0:04   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170629010300.2848-6-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=alex.bennee@linaro.org \
    --cc=cota@braap.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).