qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, qemu-block@nongnu.org, kwolf@redhat.com
Subject: [Qemu-devel] [PATCH 01/11] qcow2: call CoQueue APIs under CoMutex
Date: Thu, 29 Jun 2017 15:27:39 +0200	[thread overview]
Message-ID: <20170629132749.997-2-pbonzini@redhat.com> (raw)
In-Reply-To: <20170629132749.997-1-pbonzini@redhat.com>

Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/qcow2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index 2f94f0326e..70d3f4a18e 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1741,8 +1741,6 @@ static coroutine_fn int qcow2_co_pwritev(BlockDriverState *bs, uint64_t offset,
     ret = 0;
 
 fail:
-    qemu_co_mutex_unlock(&s->lock);
-
     while (l2meta != NULL) {
         QCowL2Meta *next;
 
@@ -1756,6 +1754,8 @@ fail:
         l2meta = next;
     }
 
+    qemu_co_mutex_unlock(&s->lock);
+
     qemu_iovec_destroy(&hd_qiov);
     qemu_vfree(cluster_data);
     trace_qcow2_writev_done_req(qemu_coroutine_self(), ret);
-- 
2.13.0

  reply	other threads:[~2017-06-29 13:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 13:27 [Qemu-devel] [PATCH v2 00/11] Block layer thread-safety, part 2 Paolo Bonzini
2017-06-29 13:27 ` Paolo Bonzini [this message]
2017-06-29 13:27 ` [Qemu-devel] [PATCH 02/11] coroutine-lock: add qemu_co_rwlock_downgrade and qemu_co_rwlock_upgrade Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 03/11] vdi: make it thread-safe Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 04/11] vpc: " Paolo Bonzini
2017-07-10 11:32   ` Fam Zheng
2017-06-29 13:27 ` [Qemu-devel] [PATCH 05/11] vvfat: " Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 06/11] qed: move tail of qed_aio_write_main to qed_aio_write_{cow, alloc} Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 07/11] block: invoke .bdrv_drain callback in coroutine context and from AioContext Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 08/11] qed: introduce bdrv_qed_init_state Paolo Bonzini
2017-06-29 15:26   ` Eric Blake
2017-07-17  3:36   ` Fam Zheng
2017-06-29 13:27 ` [Qemu-devel] [PATCH 09/11] qed: protect table cache with CoMutex Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 10/11] sheepdog: add queue_lock Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 11/11] ssh: support I/O from any AioContext Paolo Bonzini
2017-07-05 21:57 ` [Qemu-devel] [Qemu-block] [PATCH v2 00/11] Block layer thread-safety, part 2 Paolo Bonzini
2017-07-06 23:50 ` [Qemu-devel] " no-reply
2017-07-07  0:05   ` Fam Zheng
2017-07-10 12:18 ` Stefan Hajnoczi
2017-07-10 13:09 ` Fam Zheng
  -- strict thread matches above, loose matches on Subject: below --
2017-05-31  9:43 [Qemu-devel] [RFC PATCH " Paolo Bonzini
2017-05-31  9:43 ` [Qemu-devel] [PATCH 01/11] qcow2: call CoQueue APIs under CoMutex Paolo Bonzini
2017-05-31 15:18   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170629132749.997-2-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).