From: "Emilio G. Cota" <cota@braap.org>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v10 1/7] exec: [tcg] Refactor flush of per-CPU virtual TB cache
Date: Thu, 29 Jun 2017 18:22:10 -0400 [thread overview]
Message-ID: <20170629222210.GB9797@flamenco> (raw)
In-Reply-To: <149873865231.9180.13927490238451232263.stgit@frigg.lan>
On Thu, Jun 29, 2017 at 15:17:32 +0300, Lluís Vilanova wrote:
> The function is reused in later patches.
>
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> ---
> accel/tcg/cputlb.c | 2 +-
> accel/tcg/translate-all.c | 15 ++++++++++-----
> include/exec/exec-all.h | 6 ++++++
> 3 files changed, 17 insertions(+), 6 deletions(-)
Richard already picked up this patch:
tcg: consistently access cpu->tb_jmp_cache atomically
https://patchwork.kernel.org/patch/9787697/
The patch you're sending (i.e. 1/7) is a subset of that one,
so the easiest solution probably is to drop it, making sure that:
- patch 4/7 is updated to call cpu_tb_jmp_cache_clear instead of
tb_flush_jmp_cache_all
- This series is merged after that other patch is merged. If
Richard also queues then we'll be guaranteed to avoid a merge
conflict.
E.
next prev parent reply other threads:[~2017-06-29 22:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 12:13 [Qemu-devel] [PATCH v10 0/7] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches Lluís Vilanova
2017-06-29 12:17 ` [Qemu-devel] [PATCH v10 1/7] exec: [tcg] Refactor flush of per-CPU virtual TB cache Lluís Vilanova
2017-06-29 22:22 ` Emilio G. Cota [this message]
2017-06-29 12:21 ` [Qemu-devel] [PATCH v10 2/7] trace: Allocate cpu->trace_dstate in place Lluís Vilanova
2017-06-29 12:25 ` [Qemu-devel] [PATCH v10 3/7] trace: [tcg] Delay changes to dynamic state when translating Lluís Vilanova
2017-06-29 22:25 ` Emilio G. Cota
2017-06-29 12:29 ` [Qemu-devel] [PATCH v10 4/7] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state Lluís Vilanova
2017-06-29 22:35 ` Emilio G. Cota
2017-06-29 12:33 ` [Qemu-devel] [PATCH v10 5/7] trace: [tcg] Do not generate TCG code to trace dynamically-disabled events Lluís Vilanova
2017-06-29 12:37 ` [Qemu-devel] [PATCH v10 6/7] trace: [tcg, trivial] Re-align generated code Lluís Vilanova
2017-06-29 12:41 ` [Qemu-devel] [PATCH v10 7/7] trace: [trivial] Statically enable all guest events Lluís Vilanova
2017-06-29 22:36 ` Emilio G. Cota
2017-07-11 8:34 ` [Qemu-devel] [PATCH v10 0/7] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629222210.GB9797@flamenco \
--to=cota@braap.org \
--cc=crosthwaite.peter@gmail.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).