From: Jeff Cody <jcody@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v4 1/2] iotests: Use absolute paths for executables
Date: Fri, 30 Jun 2017 17:48:55 -0400 [thread overview]
Message-ID: <20170630214855.GC26034@localhost.localdomain> (raw)
In-Reply-To: <f1395eb6-46a4-9982-d625-626faac61ae3@redhat.com>
On Fri, Jun 30, 2017 at 02:45:46PM -0500, Eric Blake wrote:
> On 06/30/2017 02:41 PM, Eric Blake wrote:
>
> > +++ 068.out.bad 2017-06-30 14:35:28.720241398 -0500
> > @@ -1,4 +1,5 @@
> > QA output created by 068
> > +realpath: '': No such file or directory
> >
> > The culprit? $QEMU_VXHS_PROG is empty for me, which means `set_prog_path
> > qnio_server` found nothing to use. You'll have to add in a safety valve
> > that only calls 'type' if operating on a non-empty path in the first place.
>
> I'm using this locally, in the meantime:
>
> diff --git i/tests/qemu-iotests/common.config
> w/tests/qemu-iotests/common.config
> index c1dc425..6f97331 100644
> --- i/tests/qemu-iotests/common.config
> +++ w/tests/qemu-iotests/common.config
> @@ -107,7 +107,9 @@ export QEMU_PROG=$(realpath -- "$(type -p
> "$QEMU_PROG")")
> export QEMU_IMG_PROG=$(realpath -- "$(type -p "$QEMU_IMG_PROG")")
> export QEMU_IO_PROG=$(realpath -- "$(type -p "$QEMU_IO_PROG")")
> export QEMU_NBD_PROG=$(realpath -- "$(type -p "$QEMU_NBD_PROG")")
> -export QEMU_VXHS_PROG=$(realpath -- "$(type -p "$QEMU_VXHS_PROG")")
> +if [ -n "$QEMU_VXHS_PROG" ]; then
> + export QEMU_VXHS_PROG=$(realpath -- "$(type -p "$QEMU_VXHS_PROG")")
> +fi
>
> _qemu_wrapper()
> {
>
>
> Is qnio_server easily available for Fedora?
>
Depends on your definition of "easily". It needs to be built from the
upstream project github [1]. Most developers will likely not have it
installed.
https://github.com/VeritasHyperScale/libqnio
next prev parent reply other threads:[~2017-06-30 21:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 13:30 [Qemu-devel] [PATCH v4 0/2] iotests: Add test for colon handling Max Reitz
2017-06-21 13:30 ` [Qemu-devel] [PATCH v4 1/2] iotests: Use absolute paths for executables Max Reitz
2017-06-29 18:52 ` Eric Blake
2017-06-30 2:46 ` Max Reitz
2017-06-30 19:41 ` Eric Blake
2017-06-30 19:45 ` Eric Blake
2017-06-30 21:48 ` Jeff Cody [this message]
2017-07-02 13:35 ` Max Reitz
2017-06-21 13:30 ` [Qemu-devel] [PATCH v4 2/2] iotests: Add test for colon handling Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630214855.GC26034@localhost.localdomain \
--to=jcody@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).