From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dS4on-0006Zu-RW for qemu-devel@nongnu.org; Mon, 03 Jul 2017 13:07:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dS4ok-0002nV-Ma for qemu-devel@nongnu.org; Mon, 03 Jul 2017 13:07:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48294) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dS4ok-0002mv-Fw for qemu-devel@nongnu.org; Mon, 03 Jul 2017 13:07:22 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6629EC049E32 for ; Mon, 3 Jul 2017 17:07:21 +0000 (UTC) Date: Mon, 3 Jul 2017 14:07:12 -0300 From: Eduardo Habkost Message-ID: <20170703170712.GO12152@localhost.localdomain> References: <1499049848-18012-1-git-send-email-peterx@redhat.com> <1499049848-18012-4-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499049848-18012-4-git-send-email-peterx@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/4] doc: add item for "-M enforce-config-section" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Laurent Vivier , Juan Quintela , "Dr . David Alan Gilbert" On Mon, Jul 03, 2017 at 10:44:07AM +0800, Peter Xu wrote: > It's never documented, and now we have one more parameter for it (which > means this one can be obsolete in the future). Document it properly. > > Although now when enforce-config-section is set, it'll override the > other "-global" parameter, that is not necessarily a rule. Forbid that > usage in the document. > > Suggested-by: Eduardo Habkost > Signed-off-by: Peter Xu > --- > qemu-options.hx | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 297bd8a..927c51f 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -85,6 +85,14 @@ Enables or disables NVDIMM support. The default is off. > @item s390-squash-mcss=on|off > Enables or disables squashing subchannels into the default css. > The default is off. > +@item enforce-config-section=on|off > +Decides whether we will send the configuration section when doing > +migration. By default, it is turned on. We can set this to off to > +explicitly disable it. [...] Wait, isn't it off by default? This seems to imply that "-machine enforce-config-section=on" would have no effect at all, as the option would be already on by default. This is not the case. I suggest rewriting this as: If set to "on, force migration code to send configuration section even if the machine-type sets the "migration.send-configuration" property to "off". Note: this parameter is obsolete, please use "-global migration.send-configuration=on|off" instead. Behavior is undefined if "enforce-config-section" and "-global migration.send-configuration" are used together. (Note: we probably should use proper markup (@option/@var/@samp?) instead of quotes above, to format the option names properly in the generated documentation.) -- Eduardo