From: Kevin Wolf <kwolf@redhat.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>
Cc: qemu-devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Alberto Garcia <berto@igalia.com>, Eric Blake <eblake@redhat.com>,
qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 3/4] block: Remove bdrv_truncate callback in blkdebug
Date: Tue, 4 Jul 2017 11:57:35 +0200 [thread overview]
Message-ID: <20170704095735.GC4253@noname.str.redhat.com> (raw)
In-Reply-To: <20170704084059.6278-4-el13635@mail.ntua.gr>
Am 04.07.2017 um 10:40 hat Manos Pitsidianakis geschrieben:
> Now that bdrv_truncate is passed to bs->file by default, remove the
> callback from block/blkdebug.c
>
> Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
We'll need to set .is_filter = true for blkdebug now. I haven't yet
looked into the existing implications that this has, but intuitively
this should be okay.
When you do so, please explain in the commit message the implications
that this has.
Kevin
next prev parent reply other threads:[~2017-07-04 9:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 8:40 [Qemu-devel] [PATCH v3 0/4] block: Block driver callbacks fixes Manos Pitsidianakis
2017-07-04 8:40 ` [Qemu-devel] [PATCH v3 1/4] block: Pass bdrv_* methods to bs->file by default Manos Pitsidianakis
2017-07-04 9:44 ` Kevin Wolf
2017-07-05 12:40 ` Eric Blake
2017-07-05 12:43 ` Eric Blake
2017-07-05 13:37 ` Kevin Wolf
2017-07-04 8:40 ` [Qemu-devel] [PATCH v3 2/4] block: Use defaults of bdrv_* callbacks in raw Manos Pitsidianakis
2017-07-04 9:54 ` Kevin Wolf
2017-07-04 8:40 ` [Qemu-devel] [PATCH v3 3/4] block: Remove bdrv_truncate callback in blkdebug Manos Pitsidianakis
2017-07-04 9:57 ` Kevin Wolf [this message]
2017-07-04 8:40 ` [Qemu-devel] [PATCH v3 4/4] block: Add default implementations for bdrv_co_get_block_status() Manos Pitsidianakis
2017-07-04 10:01 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704095735.GC4253@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=el13635@mail.ntua.gr \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).