From: "Daniel P. Berrange" <berrange@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-img: delete the -e and -6 options from the 'create' command
Date: Tue, 4 Jul 2017 13:19:42 +0100 [thread overview]
Message-ID: <20170704121942.GL3135@redhat.com> (raw)
In-Reply-To: <20170704121606.GE4253@noname.str.redhat.com>
On Tue, Jul 04, 2017 at 02:16:06PM +0200, Kevin Wolf wrote:
> Am 04.07.2017 um 12:34 hat Daniel P. Berrange geschrieben:
> > The '-e' and '-6' options to the 'create' command were "deprecated"
> > in favour of the more generic '-o' option many years ago:
> >
> > commit eec77d9e712bd4157a4e1c0b5a9249d168add738
> > Author: Jes Sorensen <Jes.Sorensen@redhat.com>
> > Date: Tue Dec 7 17:44:34 2010 +0100
> >
> > qemu-img: Deprecate obsolete -6 and -e options
> >
> > Except this was never actually a deprecation, which would imply giving
> > the user a warning while the functionality continues to work for a
> > number of releases before eventual removal. Instead the options were
> > immediately turned into an error + exit. Given that the functionality
> > is already broken, there's no point in keeping these psuedo-deprecation
> > messages around any longer.
> >
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
>
> Thanks, applied to the block branch.
>
> Do you want to send another patch to do the same in qemu-img convert?
Opps, I wasn't paying attention & missed the convert command. I'll just
send a v2 of this that covers both.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2017-07-04 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 10:34 [Qemu-devel] [PATCH] qemu-img: delete the -e and -6 options from the 'create' command Daniel P. Berrange
2017-07-04 12:14 ` Kashyap Chamarthy
2017-07-04 12:16 ` Kevin Wolf
2017-07-04 12:19 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704121942.GL3135@redhat.com \
--to=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).