From: Kevin Wolf <kwolf@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] blockdev: Print a warning for legacy drive options that belong to -device
Date: Tue, 4 Jul 2017 16:40:21 +0200 [thread overview]
Message-ID: <20170704144021.GG4253@noname.str.redhat.com> (raw)
In-Reply-To: <1494585229-9119-1-git-send-email-thuth@redhat.com>
Am 12.05.2017 um 12:33 hat Thomas Huth geschrieben:
> We likely do not want to carry these legacy -drive options along forever.
> Let's emit a deprecation warning for the -drive options that have a
> replacement with the -device option, so that the (hopefully few) remaining
> users are aware of this and can adapt their scripts / behaviour accordingly.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2:
> - Check for !qtest_enabled() since tests/hd-geo-test still uses these
> - Added "addr" to the list, too
> - Also mark the options as deprecated in the documentation
Thanks, added the missing deprecation note for 'serial' in the
documentation and applied to the block branch.
Kevin
prev parent reply other threads:[~2017-07-04 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 10:33 [Qemu-devel] [PATCH v2] blockdev: Print a warning for legacy drive options that belong to -device Thomas Huth
2017-05-29 16:09 ` Thomas Huth
2017-05-30 5:20 ` Markus Armbruster
2017-05-30 7:45 ` Thomas Huth
2017-06-23 16:41 ` Thomas Huth
2017-07-04 14:40 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704144021.GG4253@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).