From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [RISU PATCH 02/11] reginfo.c: always return 1 on OP_TESTEND
Date: Tue, 4 Jul 2017 15:48:50 +0100 [thread overview]
Message-ID: <20170704144859.17644-3-alex.bennee@linaro.org> (raw)
In-Reply-To: <20170704144859.17644-1-alex.bennee@linaro.org>
In the master/apprentice setup the response byte of 1 is returned by
write_fn. However when tracing it will happily report 0 as it
successfully writes the last bytes. To avoid running of the end when
tracing we just always return 1 at this point.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
reginfo.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/reginfo.c b/reginfo.c
index d9d37b3..76f24f9 100644
--- a/reginfo.c
+++ b/reginfo.c
@@ -39,7 +39,10 @@ int send_register_info(write_fn write_fn, void *uc)
switch (op) {
case OP_TESTEND:
- return write_fn(&ri, sizeof(ri));
+ write_fn(&ri, sizeof(ri));
+ /* if we are tracing write_fn will return 0 unlike a remote
+ end, hence we force return of 1 here */
+ return 1;
case OP_SETMEMBLOCK:
memblock = (void *)(uintptr_t)get_reginfo_paramreg(&ri);
break;
--
2.13.0
next prev parent reply other threads:[~2017-07-04 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 14:48 [Qemu-devel] [RISU PATCH 00/11] Misc fixes, documentation and patterns Alex Bennée
2017-07-04 14:48 ` [Qemu-devel] [RISU PATCH 01/11] risu: make match status take tracing into account Alex Bennée
2017-07-04 14:48 ` Alex Bennée [this message]
2017-07-04 14:48 ` [Qemu-devel] [RISU PATCH 03/11] README: document --static builds Alex Bennée
2017-07-04 14:48 ` [Qemu-devel] [RISU PATCH 04/11] README: document record/replay support Alex Bennée
2017-07-04 14:48 ` [Qemu-devel] [RISU PATCH 05/11] risu.el: derive from text-mode Alex Bennée
2017-07-04 14:48 ` [Qemu-devel] [RISU PATCH 06/11] risugen: fix bad indent Alex Bennée
2017-07-04 14:48 ` [Qemu-devel] [RISU PATCH 07/11] risugen: support @GroupName in risu files Alex Bennée
2017-07-04 14:48 ` [Qemu-devel] [RISU PATCH 08/11] aarch64.risu: document naming conventions Alex Bennée
2017-07-04 14:48 ` [Qemu-devel] [RISU PATCH 09/11] aarch64.risu: remove duplicate AdvSIMD Scalar 3 same block Alex Bennée
2017-07-04 14:48 ` [Qemu-devel] [RISU PATCH 10/11] aarch64.risu: remove duplicate AdvSIMD scalar 2 reg misc block Alex Bennée
2017-07-04 14:48 ` [Qemu-devel] [RISU PATCH 11/11] aarch64.risu: update AdvancedSIMD across lanes Alex Bennée
2017-07-10 16:57 ` [Qemu-devel] [RISU PATCH 00/11] Misc fixes, documentation and patterns Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704144859.17644-3-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).