From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] hw/s390x/ipl: Fix endianness problem with netboot_start_addr
Date: Wed, 5 Jul 2017 17:38:38 +0200 [thread overview]
Message-ID: <20170705173838.0a5fb60f@dhcp-192-215.str.redhat.com> (raw)
In-Reply-To: <1499268345-12552-1-git-send-email-thuth@redhat.com>
On Wed, 5 Jul 2017 17:25:45 +0200
Thomas Huth <thuth@redhat.com> wrote:
> The start address has to be stored in big endian byte order
> in the iplb.ccw block for the guest.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/s390x/ipl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index 4e6469d..cc36003 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -418,7 +418,7 @@ void s390_ipl_prepare_cpu(S390CPU *cpu)
> error_report_err(err);
> vm_stop(RUN_STATE_INTERNAL_ERROR);
> }
> - ipl->iplb.ccw.netboot_start_addr = ipl->start_addr;
> + ipl->iplb.ccw.netboot_start_addr = cpu_to_be64(ipl->start_addr);
> }
> }
>
This seems to be the only iplb field to miss endianness handling.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2017-07-05 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 15:25 [Qemu-devel] [PATCH] hw/s390x/ipl: Fix endianness problem with netboot_start_addr Thomas Huth
2017-07-05 15:38 ` Cornelia Huck [this message]
2017-07-05 17:46 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705173838.0a5fb60f@dhcp-192-215.str.redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).