* [Qemu-devel] [PATCH] hw/s390x/ipl: Fix endianness problem with netboot_start_addr
@ 2017-07-05 15:25 Thomas Huth
2017-07-05 15:38 ` Cornelia Huck
2017-07-05 17:46 ` Christian Borntraeger
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2017-07-05 15:25 UTC (permalink / raw)
To: qemu-devel, Christian Borntraeger, Cornelia Huck; +Cc: Alexander Graf
The start address has to be stored in big endian byte order
in the iplb.ccw block for the guest.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/s390x/ipl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index 4e6469d..cc36003 100644
--- a/hw/s390x/ipl.c
+++ b/hw/s390x/ipl.c
@@ -418,7 +418,7 @@ void s390_ipl_prepare_cpu(S390CPU *cpu)
error_report_err(err);
vm_stop(RUN_STATE_INTERNAL_ERROR);
}
- ipl->iplb.ccw.netboot_start_addr = ipl->start_addr;
+ ipl->iplb.ccw.netboot_start_addr = cpu_to_be64(ipl->start_addr);
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/s390x/ipl: Fix endianness problem with netboot_start_addr
2017-07-05 15:25 [Qemu-devel] [PATCH] hw/s390x/ipl: Fix endianness problem with netboot_start_addr Thomas Huth
@ 2017-07-05 15:38 ` Cornelia Huck
2017-07-05 17:46 ` Christian Borntraeger
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2017-07-05 15:38 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, Christian Borntraeger, Alexander Graf
On Wed, 5 Jul 2017 17:25:45 +0200
Thomas Huth <thuth@redhat.com> wrote:
> The start address has to be stored in big endian byte order
> in the iplb.ccw block for the guest.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/s390x/ipl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index 4e6469d..cc36003 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -418,7 +418,7 @@ void s390_ipl_prepare_cpu(S390CPU *cpu)
> error_report_err(err);
> vm_stop(RUN_STATE_INTERNAL_ERROR);
> }
> - ipl->iplb.ccw.netboot_start_addr = ipl->start_addr;
> + ipl->iplb.ccw.netboot_start_addr = cpu_to_be64(ipl->start_addr);
> }
> }
>
This seems to be the only iplb field to miss endianness handling.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/s390x/ipl: Fix endianness problem with netboot_start_addr
2017-07-05 15:25 [Qemu-devel] [PATCH] hw/s390x/ipl: Fix endianness problem with netboot_start_addr Thomas Huth
2017-07-05 15:38 ` Cornelia Huck
@ 2017-07-05 17:46 ` Christian Borntraeger
1 sibling, 0 replies; 3+ messages in thread
From: Christian Borntraeger @ 2017-07-05 17:46 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Cornelia Huck; +Cc: Alexander Graf
On 07/05/2017 05:25 PM, Thomas Huth wrote:
> The start address has to be stored in big endian byte order
> in the iplb.ccw block for the guest.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/s390x/ipl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index 4e6469d..cc36003 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -418,7 +418,7 @@ void s390_ipl_prepare_cpu(S390CPU *cpu)
> error_report_err(err);
> vm_stop(RUN_STATE_INTERNAL_ERROR);
> }
> - ipl->iplb.ccw.netboot_start_addr = ipl->start_addr;
> + ipl->iplb.ccw.netboot_start_addr = cpu_to_be64(ipl->start_addr);
> }
> }
>
Thanks also applied to s390-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-05 17:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-05 15:25 [Qemu-devel] [PATCH] hw/s390x/ipl: Fix endianness problem with netboot_start_addr Thomas Huth
2017-07-05 15:38 ` Cornelia Huck
2017-07-05 17:46 ` Christian Borntraeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).