From: Stefan Hajnoczi <stefanha@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: Manos Pitsidianakis <el13635@mail.ntua.gr>,
qemu-devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/3] block: pass bdrv_* methods to bs->file by default
Date: Thu, 6 Jul 2017 09:40:15 +0100 [thread overview]
Message-ID: <20170706084015.GB30447@stefanha-x1.localdomain> (raw)
In-Reply-To: <1b82e5ed-73b1-34d6-9958-dfc45bebedfc@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Mon, Jul 03, 2017 at 01:40:57PM -0500, Eric Blake wrote:
> On 07/03/2017 10:56 AM, Eric Blake wrote:
> > On 06/29/2017 01:43 PM, Manos Pitsidianakis wrote:
> >> The following functions fail if bs->drv does not implement them:
>
> One other suggestion: most patches in the tree use 'topic: Capital',
> while yours used 'topic: lowercase'. It's probably worth posting a v3
> that addresses all of the nits I've pointed out, including tweaking the
> commit messages.
Plenty of regular contributors use "topic: lowercase" including Michael
Tsirkin, Mark Cave-Ayland, Peter Xu, and myself (just from looking at
the first page of git log --oneline on qemu.git/master).
If we want to enforce a consistent style in the future then it should be
discussed separately.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-07-06 8:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 18:43 [Qemu-devel] [PATCH v2 0/3] block: block driver callbacks fixes Manos Pitsidianakis
2017-06-29 18:43 ` [Qemu-devel] [PATCH v2 1/3] block: pass bdrv_* methods to bs->file by default Manos Pitsidianakis
2017-07-03 15:56 ` Eric Blake
2017-07-03 18:40 ` Eric Blake
2017-07-06 8:40 ` Stefan Hajnoczi [this message]
2017-07-06 9:09 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-06-29 18:43 ` [Qemu-devel] [PATCH v2 2/3] block: use defaults of bdrv_* callbacks in raw Manos Pitsidianakis
2017-07-03 16:05 ` Eric Blake
2017-07-06 9:40 ` Stefan Hajnoczi
2017-06-29 18:43 ` [Qemu-devel] [PATCH v2 3/3] block: add default implementations for bdrv_co_get_block_status() Manos Pitsidianakis
2017-07-03 16:12 ` Eric Blake
2017-07-03 17:51 ` Eric Blake
2017-07-03 18:24 ` Manos Pitsidianakis
2017-07-03 18:31 ` Eric Blake
2017-07-03 22:22 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706084015.GB30447@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=eblake@redhat.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).