From: Keith Busch <keith.busch@intel.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Karl Rister <krister@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/6] block: Add VFIO based NVMe driver
Date: Thu, 6 Jul 2017 13:38:02 -0400 [thread overview]
Message-ID: <20170706173801.GB27975@localhost.localdomain> (raw)
In-Reply-To: <20170705133635.11850-3-famz@redhat.com>
On Wed, Jul 05, 2017 at 09:36:31PM +0800, Fam Zheng wrote:
> This is a new protocol driver that exclusively opens a host NVMe
> controller through VFIO. It achieves better latency than linux-aio by
> completely bypassing host kernel vfs/block layer.
>
> $rw-$bs-$iodepth linux-aio nvme://
> ----------------------------------------
> randread-4k-1 8269 8851
> randread-512k-1 584 610
> randwrite-4k-1 28601 34649
> randwrite-512k-1 1809 1975
>
> The driver also integrates with the polling mechanism of iothread.
>
> This patch is co-authored by Paolo and me.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
I haven't much time to do a thorough review, but in the brief time so
far the implementation looks fine to me.
I am wondering, though, if an NVMe vfio driver can be done as its own
program that qemu can link to. The SPDK driver comes to mind as such an
example, but it may create undesirable dependencies.
next prev parent reply other threads:[~2017-07-06 17:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 13:36 [Qemu-devel] [PATCH v3 0/6] block: Add VFIO based driver for NVMe device Fam Zheng
2017-07-05 13:36 ` [Qemu-devel] [PATCH v3 1/6] stubs: Add stubs for ram block API Fam Zheng
2017-07-05 13:36 ` [Qemu-devel] [PATCH v3 2/6] block: Add VFIO based NVMe driver Fam Zheng
2017-07-06 17:38 ` Keith Busch [this message]
2017-07-06 23:27 ` Fam Zheng
2017-07-07 10:06 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
2017-07-07 17:15 ` [Qemu-devel] " Stefan Hajnoczi
2017-07-10 14:55 ` Stefan Hajnoczi
2017-07-12 2:14 ` Fam Zheng
2017-07-12 10:49 ` Stefan Hajnoczi
2017-07-05 13:36 ` [Qemu-devel] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap Fam Zheng
2017-07-10 14:57 ` Stefan Hajnoczi
2017-07-10 15:07 ` Stefan Hajnoczi
2017-07-10 15:08 ` Paolo Bonzini
2017-07-11 10:05 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-07-11 10:28 ` Paolo Bonzini
2017-07-12 1:07 ` Fam Zheng
2017-07-12 14:03 ` Paolo Bonzini
2017-07-14 13:37 ` Stefan Hajnoczi
2017-07-14 13:46 ` Paolo Bonzini
2017-07-05 13:36 ` [Qemu-devel] [PATCH v3 4/6] block/nvme: Implement .bdrv_dma_map and .bdrv_dma_unmap Fam Zheng
2017-07-10 14:59 ` Stefan Hajnoczi
2017-07-10 15:09 ` Paolo Bonzini
2017-07-11 10:04 ` Stefan Hajnoczi
2017-07-05 13:36 ` [Qemu-devel] [PATCH v3 5/6] qemu-img: Map bench buffer Fam Zheng
2017-07-05 13:36 ` [Qemu-devel] [PATCH v3 6/6] block: Move NVMe spec definitions to a separate header Fam Zheng
2017-07-05 13:39 ` Paolo Bonzini
2017-07-10 15:01 ` Stefan Hajnoczi
2017-07-05 13:41 ` [Qemu-devel] [PATCH v3 0/6] block: Add VFIO based driver for NVMe device Paolo Bonzini
2017-07-06 14:06 ` no-reply
2017-07-06 14:22 ` Paolo Bonzini
2017-07-06 14:36 ` Fam Zheng
2017-07-06 14:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706173801.GB27975@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=famz@redhat.com \
--cc=krister@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).