qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, lvivier@redhat.com,
	quintela@redhat.com, groug@kaod.org, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2.1 3/4] doc: add item for "-M enforce-config-section"
Date: Thu, 6 Jul 2017 15:30:14 -0300	[thread overview]
Message-ID: <20170706183014.GH12152@localhost.localdomain> (raw)
In-Reply-To: <1499306921-5391-1-git-send-email-peterx@redhat.com>

On Thu, Jul 06, 2017 at 10:08:41AM +0800, Peter Xu wrote:
> It's never documented, and now we have one more parameter for it (which
> obsoletes this one). Document it properly.
> 
> Although now when enforce-config-section is set, it'll override the
> other "-global" parameter, that is not necessarily a rule. Forbid that
> usage in the document.
> 
> Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> v2.1:
> - remove the "undefined behavior" sentence [Markus]
> 
>  qemu-options.hx | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 297bd8a..1ce7a37 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -85,6 +85,14 @@ Enables or disables NVDIMM support. The default is off.
>  @item s390-squash-mcss=on|off
>  Enables or disables squashing subchannels into the default css.
>  The default is off.
> +@item enforce-config-section=on|off
> +If @option{enforce-config-section} is set to @var{on}, force migration
> +code to send configuration section even if the machine-type sets the
> +@option{migration.send-configuration} property to @var{off}.
> +NOTE: this parameter is deprecated. Please use @option{-global}
> +@option{migration.send-configuration}=@var{on|off} instead.
> +@option{enforce-config-section} cannot be used together with
> +@option{-global} @option{migration.send-configuration}.
>  @end table

I'm not sure if "cannot be used together" is much better than
"behavior is undefined when they are used together".  I prefer
Markus' suggestion to simply leave it unspecified.  (In other
words, just removing the last 2 lines)

-- 
Eduardo

  parent reply	other threads:[~2017-07-06 18:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05  8:21 [Qemu-devel] [PATCH v2 0/4] migration: fix iotest 055, only-migratable break Peter Xu
2017-07-05  8:21 ` [Qemu-devel] [PATCH v2 1/4] migration: fix handling for --only-migratable Peter Xu
2017-07-05  8:21 ` [Qemu-devel] [PATCH v2 2/4] vl: move global property, migrate init earlier Peter Xu
2017-07-05  8:21 ` [Qemu-devel] [PATCH v2 3/4] doc: add item for "-M enforce-config-section" Peter Xu
2017-07-06  2:08   ` [Qemu-devel] [PATCH v2.1 " Peter Xu
2017-07-06  8:09     ` Greg Kurz
2017-07-06  8:38       ` Peter Xu
2017-07-06 18:30     ` Eduardo Habkost [this message]
2017-07-07  2:54       ` [Qemu-devel] [PATCH v2.2 " Peter Xu
2017-07-07  6:53         ` Greg Kurz
2017-07-07 12:12         ` Eduardo Habkost
2017-07-07 12:16           ` Dr. David Alan Gilbert
2017-07-10  9:02           ` Greg Kurz
2017-07-10  9:21             ` Peter Xu
2017-07-05  8:21 ` [Qemu-devel] [PATCH v2 4/4] doc: update TYPE_MIGRATION documents Peter Xu
2017-07-07 13:30   ` Eduardo Habkost
2017-07-10 12:55 ` [Qemu-devel] [PATCH v2 0/4] migration: fix iotest 055, only-migratable break Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706183014.GH12152@localhost.localdomain \
    --to=ehabkost@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=groug@kaod.org \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).