Re: [Qemu-devel] [PATCH 4/9] target-mips: Check memory permissions with mem_idx

[James Hogan <james.hogan@imgtec.com>]

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

On Fri, Oct 07, 2016 at 04:48:31PM +0100, Yongbok Kim wrote:
> On 06/09/2016 12:03, James Hogan wrote:
> > diff --git a/target-mips/helper.c b/target-mips/helper.c
> > index 29ebf391cb94..2065fc3ec119 100644
> > --- a/target-mips/helper.c
> > +++ b/target-mips/helper.c

> > @@ -413,11 +413,12 @@ static void raise_mmu_exception(CPUMIPSState *env, target_ulong address,
> >  hwaddr mips_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)
> >  {
> >      MIPSCPU *cpu = MIPS_CPU(cs);
> > +    CPUMIPSState *env = &cpu->env;
> 
> Not really useful change as it is used only once but it is ok.

Its used twice in the code below ...

> 
> >      hwaddr phys_addr;
> >      int prot;
> >  
> > -    if (get_physical_address(&cpu->env, &phys_addr, &prot, addr, 0,
> > -                             ACCESS_INT) != 0) {
> > +    if (get_physical_address(env, &phys_addr, &prot, addr, 0, ACCESS_INT,
> > +                             cpu_mmu_index(env, false)) != 0) {

... though I acknowledge it has marginal value

> Otherwise,
> 
> Reviewed-by: Yongbok Kim <yongbok.kim@imgtec.com>

Thanks
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]