qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, agraf@suse.de, thuth@redhat.com,
	pmorel@linux.vnet.ibm.com, zyimin@linux.vnet.ibm.com,
	Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PATCH RFC 4/7] s390x/ccw: create s390 phb conditionally
Date: Fri,  7 Jul 2017 14:21:56 +0200	[thread overview]
Message-ID: <20170707122159.24714-5-cohuck@redhat.com> (raw)
In-Reply-To: <20170707122159.24714-1-cohuck@redhat.com>

Don't create the s390 pci host bridge for non-pci builds.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/s390x/s390-virtio-ccw.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 41ca6668e2..563f7702a1 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -114,7 +114,6 @@ static void ccw_init(MachineState *machine)
 {
     int ret;
     VirtualCssBus *css_bus;
-    DeviceState *dev;
 
     s390_sclp_init();
     s390_memory_init(machine->ram_size);
@@ -126,12 +125,14 @@ static void ccw_init(MachineState *machine)
     s390_init_ipl_dev(machine->kernel_filename, machine->kernel_cmdline,
                       machine->initrd_filename, "s390-ccw.img",
                       "s390-netboot.img", true);
-
-    dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);
+#ifdef CONFIG_PCI
+    {
+    DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);
     object_property_add_child(qdev_get_machine(), TYPE_S390_PCI_HOST_BRIDGE,
                               OBJECT(dev), NULL);
     qdev_init_nofail(dev);
-
+    }
+#endif
     /* register hypercalls */
     virtio_ccw_register_hcalls();
 
-- 
2.13.0

  parent reply	other threads:[~2017-07-07 12:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07 12:21 [Qemu-devel] [PATCH RFC 0/7] s390x: zPCI detangling Cornelia Huck
2017-07-07 12:21 ` [Qemu-devel] [PATCH RFC 1/7] kvm: remove hard dependency on pci Cornelia Huck
2017-07-07 13:11   ` Thomas Huth
2017-07-07 13:15     ` Cornelia Huck
2017-07-07 12:21 ` [Qemu-devel] [PATCH RFC 2/7] s390x: chsc nt2 events are pci-only Cornelia Huck
2017-07-07 13:01   ` Christian Borntraeger
2017-07-07 13:11     ` Cornelia Huck
2017-07-07 12:21 ` [Qemu-devel] [PATCH RFC 3/7] s390x/sclp: properly guard pci-specific functions Cornelia Huck
2017-07-07 12:21 ` Cornelia Huck [this message]
2017-07-07 12:21 ` [Qemu-devel] [PATCH RFC 5/7] s390x/pci: fence off instructions for non-pci Cornelia Huck
2017-07-07 12:55   ` Christian Borntraeger
2017-07-07 13:04     ` Cornelia Huck
2017-07-10 11:04       ` Cornelia Huck
2017-07-10 12:41         ` Christian Borntraeger
2017-07-10 12:54           ` Cornelia Huck
2017-07-07 13:00   ` Thomas Huth
2017-07-07 13:10     ` Cornelia Huck
2017-07-07 12:21 ` [Qemu-devel] [PATCH RFC 6/7] s390x/kvm: msi route fixup " Cornelia Huck
2017-07-07 12:21 ` [Qemu-devel] [PATCH RFC 7/7] s390x: refine pci dependencies Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170707122159.24714-5-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=zyimin@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).