From: "Emilio G. Cota" <cota@braap.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: yang.zhong@intel.com, thuth@redhat.com, qemu-devel@nongnu.org,
a.rigo@virtualopensystems.com, anthony.xu@intel.com,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 09/22] monitor: disable "info jit" and "info opcount" if !TCG
Date: Sun, 9 Jul 2017 04:13:51 -0400 [thread overview]
Message-ID: <20170709081351.GA24967@flamenco> (raw)
In-Reply-To: <20170706202652.GA18201@flamenco>
On Thu, Jul 06, 2017 at 16:26:52 -0400, Emilio G. Cota wrote:
> On Tue, Jul 04, 2017 at 13:12:02 +0200, Paolo Bonzini wrote:
> > Reviewed-by: Richard Henderson <rth@twiddle.net>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(snip)
> > +++ b/accel/tcg/translate-all.c
> > @@ -1851,6 +1851,11 @@ void dump_exec_info(FILE *f, fprintf_function cpu_fprintf)
> >
> > tb_lock();
> >
> > + if (!tcg_enabled()) {
> > + cpu_fprintf(f, "TCG not enabled\n");
> > + return;
> > + }
>
> Sorry I missed this before it was merged, but:
>
> - We're returning with tb_lock held
> - This check is redundant; see b7da97eef ("monitor: Check whether TCG
> is enabled before running the "info jit" code") which was merged
> in April (hmp_info_jit is the only caller of dump_exec_info).
>
> I suggest we get rid of the check, although moving it above tb_lock is
> also OK with me.
Patch here:
https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg02072.html
This other patch fixes another issue introduced in this series, please
have a look as well:
https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg02058.html
Cheers,
Emilio
next prev parent reply other threads:[~2017-07-09 8:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 11:11 [Qemu-devel] [PATCH v4 00/22] add disable-tcg option for x86 build Paolo Bonzini
2017-07-04 11:11 ` [Qemu-devel] [PATCH 01/22] configure: factor out list of supported Xen/KVM/HAX targets Paolo Bonzini
2017-07-04 11:11 ` [Qemu-devel] [PATCH 02/22] configure: early test for supported targets Paolo Bonzini
2017-07-04 12:41 ` Daniel P. Berrange
2017-07-04 11:11 ` [Qemu-devel] [PATCH 03/22] configure: add --disable-tcg configure option Paolo Bonzini
2017-07-04 11:11 ` [Qemu-devel] [PATCH 04/22] vl: convert -tb-size to qemu_strtoul Paolo Bonzini
2017-07-04 11:11 ` [Qemu-devel] [PATCH 05/22] vl: add tcg_enabled() for tcg related code Paolo Bonzini
2017-07-04 11:11 ` [Qemu-devel] [PATCH 06/22] tcg: move page_size_init() function Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 07/22] tcg: tcg_handle_interrupt() function Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 08/22] tcg: make tcg_allowed global Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 09/22] monitor: disable "info jit" and "info opcount" if !TCG Paolo Bonzini
2017-07-06 20:26 ` Emilio G. Cota
2017-07-09 8:13 ` Emilio G. Cota [this message]
2017-07-04 11:12 ` [Qemu-devel] [PATCH 10/22] vapic: use tcg_enabled Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 11/22] tcg: add the tcg-stub.c file into accel/stubs/ Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 12/22] tcg: move tb_lock out of translate-all.h Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 13/22] exec: elide calls to tb_lock and tb_unlock Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 14/22] tcg: add CONFIG_TCG guards in headers Paolo Bonzini
2017-07-04 18:29 ` Richard Henderson
2017-07-04 11:12 ` [Qemu-devel] [PATCH 15/22] tcg: add the CONFIG_TCG into Makefiles Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 16/22] target/i386: move cpu_sync_bndcs_hflags() function Paolo Bonzini
2017-07-04 18:30 ` Richard Henderson
2017-07-04 11:12 ` [Qemu-devel] [PATCH 17/22] target/i386: make cpu_get_fp80()/cpu_set_fp80() static Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 18/22] target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline Paolo Bonzini
2017-07-04 18:31 ` Richard Henderson
2017-07-04 11:12 ` [Qemu-devel] [PATCH 19/22] target/i386: move TLB refill function out of helper.c Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 20/22] target/i386: add the tcg_enabled() in target/i386/ Paolo Bonzini
2017-07-04 18:33 ` Richard Henderson
2017-07-04 11:12 ` [Qemu-devel] [PATCH 21/22] target/i386: add the CONFIG_TCG into Makefiles Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 22/22] configure: warn on untested --disable-tcg Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2017-07-03 16:34 [Qemu-devel] [PATCH v3 00/22] add disable-tcg option for x86 build Paolo Bonzini
2017-07-03 16:34 ` [Qemu-devel] [PATCH 09/22] monitor: disable "info jit" and "info opcount" if !TCG Paolo Bonzini
2017-07-03 20:02 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170709081351.GA24967@flamenco \
--to=cota@braap.org \
--cc=a.rigo@virtualopensystems.com \
--cc=anthony.xu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).