From: Fam Zheng <famz@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] block: fix possible return code clobbering in bdrv_co_pdiscard
Date: Mon, 10 Jul 2017 16:56:36 +0800 [thread overview]
Message-ID: <20170710085636.GB8951@lemon.lan> (raw)
In-Reply-To: <20170710083553.6167-1-den@openvz.org>
On Mon, 07/10 11:35, Denis V. Lunev wrote:
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Stefan Hajnoczi <stefanha@redhat.com> (supporter:Block I/O path)
> CC: Fam Zheng <famz@redhat.com> (supporter:Block I/O path)
Maybe use "--noroles"? The parenthesis part is not really useful.
> ---
> block/io.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/io.c b/block/io.c
> index ed31810c0a..e5c6dc77d3 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -2464,7 +2464,6 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs, int64_t offset,
> assert(max_pdiscard >= bs->bl.request_alignment);
>
> while (count > 0) {
> - int ret;
> int num = count;
>
> if (head) {
> --
> 2.11.0
>
>
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2017-07-10 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 8:35 [Qemu-devel] [PATCH 1/1] block: fix possible return code clobbering in bdrv_co_pdiscard Denis V. Lunev
2017-07-10 8:56 ` Fam Zheng [this message]
2017-07-10 8:59 ` Denis V. Lunev
2017-07-10 13:51 ` Eric Blake
2017-07-10 14:31 ` Denis V. Lunev
2017-07-10 13:59 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2017-07-10 14:31 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710085636.GB8951@lemon.lan \
--to=famz@redhat.com \
--cc=den@openvz.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).