From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUUzU-0000Si-R8 for qemu-devel@nongnu.org; Mon, 10 Jul 2017 05:28:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUUzR-00039v-Ns for qemu-devel@nongnu.org; Mon, 10 Jul 2017 05:28:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63905) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dUUzR-00038H-IE for qemu-devel@nongnu.org; Mon, 10 Jul 2017 05:28:25 -0400 Date: Mon, 10 Jul 2017 17:28:13 +0800 From: Peter Xu Message-ID: <20170710092813.GD3738@pxdev.xzpeter.org> References: <20170628190047.26159-1-dgilbert@redhat.com> <20170628190047.26159-2-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170628190047.26159-2-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [RFC 01/29] RAMBlock/migration: Add migration flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, a.perevalov@samsung.com, marcandre.lureau@redhat.com, maxime.coquelin@redhat.com, mst@redhat.com, quintela@redhat.com, lvivier@redhat.com, aarcange@redhat.com On Wed, Jun 28, 2017 at 08:00:19PM +0100, Dr. David Alan Gilbert (git) wrote: [...] > diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h > index af5bf26080..0cb6c5cb73 100644 > --- a/include/exec/ram_addr.h > +++ b/include/exec/ram_addr.h > @@ -32,6 +32,8 @@ struct RAMBlock { > ram_addr_t max_length; > void (*resized)(const char*, uint64_t length, void *host); > uint32_t flags; > + /* These flags are owned by migration, initialised to 0 */ > + uint32_t migration_flags; Since we have RAMBlock.flags, would it be possible to use that directly? Currently it only used 3 bits. Thanks, -- Peter Xu