From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Emilio G. Cota" <cota@braap.org>
Cc: qemu-devel@nongnu.org,
"Daniel P . Berrange" <berrange@redhat.com>,
"Lluís Vilanova" <vilanova@ac.upc.edu>,
"Richard Henderson" <rth@twiddle.net>,
"Laurent Desnogues" <laurent.desnogues@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v9 0/7] trace: Optimize per-vCPU TCG tracing states
Date: Mon, 10 Jul 2017 13:07:44 +0100 [thread overview]
Message-ID: <20170710120744.GC14195@stefanha-x1.localdomain> (raw)
In-Reply-To: <1498514681-3059-1-git-send-email-cota@braap.org>
[-- Attachment #1: Type: text/plain, Size: 1751 bytes --]
On Mon, Jun 26, 2017 at 06:04:34PM -0400, Emilio G. Cota wrote:
> v8: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02335.html
>
> Changes from v8:
>
> - Rebased on top of the current tracing tree -- the one that includes
> Lluis' fix (2c321e3c486).
> - Added Lluis' R-b tag.
> - Added perf numbers in the commit log of the last patch (tl;dr: no overhead).
>
> Thanks,
>
> Emilio
>
> PS. How to quickly get some linux-user perf numbers:
>
> I used dbt-bench[1] for a before/after comparison. I added a script to that
> repo (breakdown.pl, see below) to make it play well with barchart[2].
> Obtaining a comparison bar chart is quite simple:
>
> 1. Generate one dbt-bench output file per QEMU checkout, e.g.:
> $ git checkout orig && make
> [ orig == "before"; new == "after" ]
> $ ./dbt-bench.pl /path/to/qemu/build/qemu-x86_64 > orig.out
> [ then do the same with orig-disabled, new, etc.]
> [...]
> $ ls *.out
> new-disabled.out new.out orig-enabled.out orig.out
>
> 2. Call dbt-bench's breakdown.pl script with the --barchart option, then
> pipe the output to barchart, and finally pipe to gnuplot:
> $ ./breakdown.pl --barchart orig.out orig-enabled.out new.out new-disabled.out \
> | ../barchart/barchart.pl --extra-gnuplot='set term dumb 140 30' \
> --extra-gnuplot='set title "NBench score; higher is better"' \
> | gnuplot
>
> Note that barchart is just a front-end for gnuplot >=5, so any valid term will
> work (e.g. 'set term pngcairo size 1200,500').
>
> [1] https://github.com/cota/dbt-bench
> [2] https://github.com/cota/barchart
>
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-07-10 12:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 22:04 [Qemu-devel] [PATCH v9 0/7] trace: Optimize per-vCPU TCG tracing states Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 1/7] exec: [tcg] Refactor flush of per-CPU virtual TB cache Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 2/7] cpu: allocate cpu->trace_dstate in place Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 3/7] trace: [tcg] Delay changes to dynamic state when translating Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 4/7] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 5/7] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 6/7] trace: [tcg, trivial] Re-align generated code Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 7/7] trace: Statically enable all TCG guest events Emilio G. Cota
2017-07-10 12:07 ` Stefan Hajnoczi [this message]
2017-07-11 10:55 ` [Qemu-devel] [PATCH v9 0/7] trace: Optimize per-vCPU TCG tracing states Stefan Hajnoczi
2017-07-11 12:35 ` Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710120744.GC14195@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).