From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"open list:Network Block Dev..." <qemu-block@nongnu.org>
Subject: [Qemu-devel] [PULL 08/11] nbd/server: fix TRACE in nbd_negotiate_send_rep_len
Date: Mon, 10 Jul 2017 07:14:31 -0500 [thread overview]
Message-ID: <20170710121434.5047-9-eblake@redhat.com> (raw)
In-Reply-To: <20170710121434.5047-1-eblake@redhat.com>
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Fix wrong order of TRACE arguments.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20170707152918.23086-8-vsementsov@virtuozzo.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
---
nbd/server.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nbd/server.c b/nbd/server.c
index e3fd0ca..1eeafcc 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -139,7 +139,7 @@ static int nbd_negotiate_send_rep_len(QIOChannel *ioc, uint32_t type,
uint64_t magic;
TRACE("Reply opt=%" PRIx32 " type=%" PRIx32 " len=%" PRIu32,
- type, opt, len);
+ opt, type, len);
magic = cpu_to_be64(NBD_REP_MAGIC);
if (nbd_write(ioc, &magic, sizeof(magic), errp) < 0) {
--
2.9.4
next prev parent reply other threads:[~2017-07-10 12:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 12:14 [Qemu-devel] [PULL 00/11] NBD patches Eric Blake
2017-07-10 12:14 ` [Qemu-devel] [PULL 01/11] MAINTAINERS: Promote NBD to supported, with new maintainer Eric Blake
2017-07-10 14:47 ` Eric Blake
2017-07-10 12:14 ` [Qemu-devel] [PULL 02/11] nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT Eric Blake
2017-07-10 12:14 ` [Qemu-devel] [PULL 03/11] nbd/server: refactor nbd_negotiate Eric Blake
2017-07-10 12:14 ` [Qemu-devel] [PULL 04/11] nbd/server: use errp instead of LOG Eric Blake
2017-07-10 12:14 ` [Qemu-devel] [PULL 05/11] nbd/server: add errp to nbd_send_reply() Eric Blake
2017-07-10 12:14 ` [Qemu-devel] [PULL 06/11] nbd/common: nbd_tls_handshake: remove extra TRACE Eric Blake
2017-07-10 12:14 ` [Qemu-devel] [PULL 07/11] nbd/client: refactor TRACE of NBD_MAGIC Eric Blake
2017-07-10 12:14 ` Eric Blake [this message]
2017-07-10 12:14 ` [Qemu-devel] [PULL 09/11] nbd/server: rename clientflags var in nbd_negotiate_options Eric Blake
2017-07-10 12:14 ` [Qemu-devel] [PULL 10/11] nbd: refactor tracing Eric Blake
2017-07-10 12:14 ` [Qemu-devel] [PULL 11/11] nbd: use generic trace subsystem instead of TRACE macro Eric Blake
2017-07-10 14:24 ` [Qemu-devel] [PULL 00/11] NBD patches Peter Maydell
2017-07-10 14:44 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710121434.5047-9-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).