From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUYne-0005zt-Oc for qemu-devel@nongnu.org; Mon, 10 Jul 2017 09:32:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUYnd-0003T6-M2 for qemu-devel@nongnu.org; Mon, 10 Jul 2017 09:32:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37628) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dUYnd-0003So-F5 for qemu-devel@nongnu.org; Mon, 10 Jul 2017 09:32:29 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 70F2161D07 for ; Mon, 10 Jul 2017 13:32:28 +0000 (UTC) Date: Mon, 10 Jul 2017 14:32:14 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170710133213.GC16073@work-vm> References: <20170628095228.4661-1-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170628095228.4661-1-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/5] Create setup/cleanup methods for migration incoming side List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com, kwolf@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > Hi Queued. > Changes from v4: > - make sure that we call save_cleanup() in postocpy (dave). > > Please, review. > > [v3] > - rename htab_cleanup htab_save_cleanup (dave) > - loaded_data was needed because caller can need it (dave) > - improve error message (dave) > > Please, review. > > [v2] > - Kevin detected that I didn't called load_cleanup(), fix it. > - Be consistent and change the naming of the functions so they are all: > qemu_savevm_state_* or qemu_loadvm_state* > - the traces still used the all names of _begin, instead of _setup, > fix that. > > Please, review. > > Later, Juan. > > PD: Yes, now that the includes are internal, we coauld rename > "qemu_savevm_state_" to something shorter, like `savevm_". The > same for the loadvm counterparts. But I am not doing any such > changes soon, too much churn for so little gain. > > [v1] > This series make: > - use of cleanup/save methods generic, not only for save_live methods > - create the equivalent methods for the load side (load_setup/cleanup) > - Make ram use this methods to see how/when they are used. > > Stefan, Kevin, this were the methods that you asked for the block.c > migration, right? Please, comment if they are enough for you. > > Juan Quintela (5): > migration: Rename save_live_setup() to save_setup() > migration: Rename cleanup() to save_cleanup() > migration: Create load_setup()/cleanup() methods > migration: Convert ram to use new load_setup()/load_cleanup() > migration: Make compression_threads use save/load_setup/cleanup() > > hw/ppc/spapr.c | 6 ++--- > include/migration/register.h | 6 +++-- > migration/block.c | 4 +-- > migration/colo.c | 2 +- > migration/migration.c | 10 +------ > migration/ram.c | 63 +++++++++++++++++++++++++++++++------------- > migration/ram.h | 6 ----- > migration/savevm.c | 61 +++++++++++++++++++++++++++++++++++------- > migration/savevm.h | 3 ++- > migration/trace-events | 4 ++- > 10 files changed, 113 insertions(+), 52 deletions(-) > > -- > 2.9.4 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK