From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUZDg-00063L-Qr for qemu-devel@nongnu.org; Mon, 10 Jul 2017 09:59:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUZDg-0000jn-1P for qemu-devel@nongnu.org; Mon, 10 Jul 2017 09:59:24 -0400 Date: Mon, 10 Jul 2017 15:59:02 +0200 From: Kevin Wolf Message-ID: <20170710135902.GL5772@noname.redhat.com> References: <20170710083553.6167-1-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170710083553.6167-1-den@openvz.org> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] block: fix possible return code clobbering in bdrv_co_pdiscard List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: qemu-devel@nongnu.org, Fam Zheng , Stefan Hajnoczi , qemu-block@nongnu.org Am 10.07.2017 um 10:35 hat Denis V. Lunev geschrieben: > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi (supporter:Block I/O path) > CC: Fam Zheng (supporter:Block I/O path) > --- > block/io.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/io.c b/block/io.c > index ed31810c0a..e5c6dc77d3 100644 > --- a/block/io.c > +++ b/block/io.c > @@ -2464,7 +2464,6 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs, int64_t offset, > assert(max_pdiscard >= bs->bl.request_alignment); > > while (count > 0) { > - int ret; > int num = count; > > if (head) { Good catch, and the fix looks fine. This needs rebasing, though (conflicts with commit f5a5ca7 'block: change variable names in BlockDriverState'). Kevin