From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUZwn-0000EZ-I6 for qemu-devel@nongnu.org; Mon, 10 Jul 2017 10:46:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUZwm-0006gy-Mt for qemu-devel@nongnu.org; Mon, 10 Jul 2017 10:46:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43958) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dUZwm-0006fO-EU for qemu-devel@nongnu.org; Mon, 10 Jul 2017 10:46:00 -0400 Date: Mon, 10 Jul 2017 11:45:57 -0300 From: Eduardo Habkost Message-ID: <20170710144557.GH12152@localhost.localdomain> References: <20170707213052.13087-1-ehabkost@redhat.com> <20170707213052.13087-2-ehabkost@redhat.com> <20170710101041.553a792a@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170710101041.553a792a@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] tests: Test case for object_resolve_path*() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= On Mon, Jul 10, 2017 at 10:10:41AM +0200, Igor Mammedov wrote: > On Fri, 7 Jul 2017 18:30:51 -0300 > Eduardo Habkost wrote: > > > Test for partial path lookup using object_resolve_path*(). > > > > Signed-off-by: Eduardo Habkost > > --- > > tests/check-qom-proplist.c | 41 +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 41 insertions(+) > > > > diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c > > index 8e432e9..abafbd7 100644 > > --- a/tests/check-qom-proplist.c > > +++ b/tests/check-qom-proplist.c > > @@ -568,6 +568,46 @@ static void test_dummy_delchild(void) > > object_unparent(OBJECT(dev)); > > } > > > > +static void test_qom_partial_path(void) > > +{ > > + Object *root = object_get_objects_root(); > > + Object *cont1 = container_get(root, "/cont1"); > > + Object *obj1 = object_new(TYPE_DUMMY); > > + Object *obj2a = object_new(TYPE_DUMMY); > > + Object *obj2b = object_new(TYPE_DUMMY); > > + bool ambiguous; > > + > > + /* Objects created: > > + * /cont1 > > + * /cont1/obj1 > > + * /cont1/obj2 (obj2a) > > + * /obj2 (obj2b) > > + */ > > + object_property_add_child(cont1, "obj1", obj1, &error_abort); > > + object_unref(obj1); > > + object_property_add_child(cont1, "obj2", obj2a, &error_abort); > > + object_unref(obj2a); > > + object_property_add_child(root, "obj2", obj2b, &error_abort); > > + object_unref(obj2b); > > + > > + ambiguous = false; > > + g_assert(!object_resolve_path_type("", TYPE_DUMMY, &ambiguous)); > > + g_assert(ambiguous); > > + > > + ambiguous = false; > > + g_assert(!object_resolve_path("obj2", &ambiguous)); > > + g_assert(ambiguous); > > + > > + ambiguous = false; > > + g_assert(object_resolve_path("obj1", &ambiguous) == obj1); > > + g_assert(!ambiguous); > > I'd also add test case for > object_resolve_path(..., NULL) They are added by patch 2/2, after the bug is fixed. > > > + > > + object_unparent(obj1); > > + object_unparent(obj2a); > > + object_unparent(obj2b); > Are above unparenting is necessary? > > > + object_unparent(cont1); > Wouldn't parent destruction sufficient to trigger > implicit destruction of children? Probably it is. I will test it. -- Eduardo