From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUaGK-0001Ow-Kv for qemu-devel@nongnu.org; Mon, 10 Jul 2017 11:06:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUaGJ-0000QA-PK for qemu-devel@nongnu.org; Mon, 10 Jul 2017 11:06:12 -0400 From: "Denis V. Lunev" Date: Mon, 10 Jul 2017 18:05:59 +0300 Message-Id: <20170710150559.30163-1-den@openvz.org> Subject: [Qemu-devel] [PATCH v2 1/1] block: fix shadowed variable in bdrv_co_pdiscard List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, "Denis V. Lunev" , Stefan Hajnoczi , Kevin Wolf , Eric Blake We've had a shadowed 'ret' variable, which risks returning the wrong value, introduced in commit b9c64947. Signed-off-by: Denis V. Lunev Reviewed-by: Fam Zheng CC: Stefan Hajnoczi CC: Kevin Wolf CC: Eric Blake --- block/io.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/io.c b/block/io.c index 23170a57ee..87208990c4 100644 --- a/block/io.c +++ b/block/io.c @@ -2327,7 +2327,6 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs, int64_t offset, assert(max_pdiscard >= bs->bl.request_alignment); while (bytes > 0) { - int ret; int num = bytes; if (head) { -- 2.11.0