From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org, rth@twiddle.net, cota@braap.org
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH v1 0/6] DISAS_UPDATE fixes for eret
Date: Mon, 10 Jul 2017 16:47:43 +0100 [thread overview]
Message-ID: <20170710154749.13624-1-alex.bennee@linaro.org> (raw)
Hi,
This is a follow-up to the eret patch I posted on Friday:
https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg01831.html
It fixes the same bug but does it in a slightly more holistic way. We
start by expanding the commentary on the common DISAS_n exit flags in
exec-all.h. I then update ARMs usage of DISAS_UPDATE to:
- explicitly exit the run-loop (and not fall-through to DISAS_JUMP)
- make setting the PC optional (as helpers may set it)
I then get rid of the architecture specific hack DISAS_EXIT and use
DISAS_UPDATE for all the eret paths.
Please review.
Alex Bennée (6):
include/exec/exec-all: document common exit conditions
target/arm/translate.c: make DISAS_UPDATE match declared semantics
target/arm/translate-a64: make DISAS_UPDATE match declared semantics
target/arm/translate-a64: get rid of DISAS_EXIT
target/arm: use DISAS_JUMP for ISB handling
target/arm: ensure eret exits the run-loop via DISAS_UPDATE
include/exec/exec-all.h | 29 ++++++++++++++++++++++++++---
target/arm/translate-a64.c | 21 +++++++++++----------
target/arm/translate.c | 36 ++++++++++++++++++++++++++----------
target/arm/translate.h | 4 ----
4 files changed, 63 insertions(+), 27 deletions(-)
--
2.13.0
next reply other threads:[~2017-07-10 15:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 15:47 Alex Bennée [this message]
2017-07-10 15:47 ` [Qemu-devel] [PATCH v1 1/6] include/exec/exec-all: document common exit conditions Alex Bennée
2017-07-10 15:47 ` [Qemu-devel] [PATCH v1 2/6] target/arm/translate.c: make DISAS_UPDATE match declared semantics Alex Bennée
2017-07-10 16:13 ` Peter Maydell
2017-07-10 16:31 ` Richard Henderson
2017-07-10 18:35 ` Alex Bennée
2017-07-10 18:55 ` Richard Henderson
2017-07-10 15:47 ` [Qemu-devel] [PATCH v1 3/6] target/arm/translate-a64: " Alex Bennée
2017-07-10 15:47 ` [Qemu-devel] [PATCH v1 4/6] target/arm/translate-a64: get rid of DISAS_EXIT Alex Bennée
2017-07-10 16:37 ` Richard Henderson
2017-07-10 15:47 ` [Qemu-devel] [PATCH v1 5/6] target/arm: use DISAS_JUMP for ISB handling Alex Bennée
2017-07-10 15:47 ` [Qemu-devel] [PATCH v1 6/6] target/arm: ensure eret exits the run-loop via DISAS_UPDATE Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710154749.13624-1-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).