From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com,
famz@redhat.com, stefanha@redhat.com, amit.shah@redhat.com,
quintela@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
peter.maydell@linaro.org, dgilbert@redhat.com, den@openvz.org,
jsnow@redhat.com, vsementsov@virtuozzo.com, lirans@il.ibm.com
Subject: [Qemu-devel] [PATCH v7 10/16] migration: add is_active_iterate handler
Date: Mon, 10 Jul 2017 19:30:23 +0300 [thread overview]
Message-ID: <20170710163029.129912-11-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20170710163029.129912-1-vsementsov@virtuozzo.com>
Only-postcopy savevm states (dirty-bitmap) don't need live iteration, so
to disable them and stop transporting empty sections there is a new
savevm handler.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
---
include/migration/register.h | 1 +
migration/savevm.c | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/include/migration/register.h b/include/migration/register.h
index ebf68992dd..3655341544 100644
--- a/include/migration/register.h
+++ b/include/migration/register.h
@@ -25,6 +25,7 @@ typedef struct SaveVMHandlers {
/* This runs both outside and inside the iothread lock. */
bool (*is_active)(void *opaque);
bool (*has_postcopy)(void *opaque);
+ bool (*is_active_iterate)(void *opaque);
/* This runs outside the iothread lock in the migration case, and
* within the lock in the savevm case. The callback had better only
diff --git a/migration/savevm.c b/migration/savevm.c
index 0ab036489a..f03ee02f67 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1024,6 +1024,11 @@ int qemu_savevm_state_iterate(QEMUFile *f, bool postcopy)
continue;
}
}
+ if (se->ops && se->ops->is_active_iterate) {
+ if (!se->ops->is_active_iterate(se->opaque)) {
+ continue;
+ }
+ }
/*
* In the postcopy phase, any device that doesn't know how to
* do postcopy should have saved it's state in the _complete
--
2.11.1
next prev parent reply other threads:[~2017-07-10 16:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 16:30 [Qemu-devel] [PATCH v7 00/16] Dirty bitmaps postcopy migration Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 01/16] migration: add has_postcopy savevm handler Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 02/16] migration: fix ram_save_pending Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 03/16] migration: split common postcopy out of ram postcopy Vladimir Sementsov-Ogievskiy
2017-07-11 13:06 ` Dr. David Alan Gilbert
2017-07-11 13:38 ` Vladimir Sementsov-Ogievskiy
2017-08-21 23:34 ` John Snow
2017-09-18 14:07 ` [Qemu-devel] ping " Vladimir Sementsov-Ogievskiy
2017-09-19 19:06 ` Dr. David Alan Gilbert
2017-09-20 11:45 ` Juan Quintela
2017-09-25 13:23 ` Kevin Wolf
2017-09-25 14:31 ` Vladimir Sementsov-Ogievskiy
2017-09-25 14:58 ` Kevin Wolf
2017-09-25 15:07 ` Vladimir Sementsov-Ogievskiy
2017-09-25 15:27 ` Dr. David Alan Gilbert
2017-09-26 10:12 ` Kevin Wolf
2017-09-26 10:21 ` Dr. David Alan Gilbert
2017-09-26 12:32 ` Kevin Wolf
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 04/16] migration: introduce postcopy-only pending Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 05/16] block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor() Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 06/16] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2017-07-10 21:03 ` Eric Blake
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 07/16] block/dirty-bitmap: add bdrv_dirty_bitmap_release_successor Vladimir Sementsov-Ogievskiy
2017-08-14 9:37 ` Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 08/16] migration: include migrate_dirty_bitmaps in migrate_postcopy Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 09/16] migration/qemu-file: add qemu_put_counted_string() Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` Vladimir Sementsov-Ogievskiy [this message]
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 11/16] block/dirty-bitmap: add bdrv_dirty_bitmap_set_frozen Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 12/16] migration: add postcopy migration of dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-09-18 14:07 ` Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 13/16] iotests: add add_incoming_migration to VM class Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 14/16] iotests: add default node-name Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 15/16] iotests: add dirty bitmap migration test Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 16/16] iotests: add dirty bitmap postcopy test Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710163029.129912-11-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lirans@il.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).