From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: agraf@suse.de, mdroth@linux.vnet.ibm.com, groug@kaod.org,
bharata@linux.vnet.ibm.com, lvivier@redhat.com, aik@ozlabs.ru,
surajjs@au1.ibm.com, sbobroff@au1.ibm.com, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 14/17] spapr: Only report host/guest IOMMU page size mismatches on KVM
Date: Tue, 11 Jul 2017 14:39:14 +1000 [thread overview]
Message-ID: <20170711043917.1757-15-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20170711043917.1757-1-david@gibson.dropbear.id.au>
We print a warning if the spapr IOMMU isn't configured to support a page
size matching the host page size backing RAM. When that's the case we need
more complex logic to translate VFIO mappings, which is slower.
But, it's not so slow that it would be at all noticeable against the
general slowness of TCG. So, only warn when using KVM. This removes some
noisy and unhelpful warnings from make check on hosts with page sizes
which typically differ from those on POWER (e.g. Sparc).
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
hw/ppc/spapr_pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index cc1588d..a52dcf8 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1745,7 +1745,8 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp)
}
/* DMA setup */
- if ((sphb->page_size_mask & qemu_getrampagesize()) == 0) {
+ if (((sphb->page_size_mask & qemu_getrampagesize()) == 0)
+ && kvm_enabled()) {
error_report("System page size 0x%lx is not enabled in page_size_mask "
"(0x%"PRIx64"). Performance may be slow",
qemu_getrampagesize(), sphb->page_size_mask);
--
2.9.4
next prev parent reply other threads:[~2017-07-11 4:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 4:39 [Qemu-devel] [PULL 00/17] ppc-for-2.10 queue 20170711 David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 01/17] spapr: make spapr_populate_hotplug_cpu_dt() static David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 02/17] spapr: refresh "platform-specific" hcalls comment David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 03/17] spapr: fix bogus function name in comment David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 04/17] spapr: fix migration to pseries machine < 2.8 David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 05/17] target-ppc: SPR_BOOKE_ESR not set on FP exceptions David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 06/17] spapr: Leave DR-indicator management to the guest David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 07/17] spapr: Uniform DRC reset paths David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 08/17] spapr: Add DRC release method David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 09/17] spapr: Remove unnecessary differences between hotplug and coldplug paths David Gibson
2017-07-12 8:26 ` Bharata B Rao
2017-07-12 9:29 ` Greg Kurz
2017-07-12 9:40 ` David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 10/17] spapr: Use unplug_request for PCI hot unplug David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 11/17] target/ppc: Refactor tcg radix mmu code David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 12/17] target/ppc: Add debug function for radix mmu translation David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 13/17] spapr: fix memory hotplug error path David Gibson
2017-07-11 4:39 ` David Gibson [this message]
2017-07-11 4:39 ` [Qemu-devel] [PULL 15/17] ppc/kvm: have the "family" CPU alias to point to TYPE_HOST_POWERPC_CPU David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 16/17] spapr: introduce the XIVE_EXPLOIT option in CAS David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 17/17] spapr: populate device tree depending on XIVE_EXPLOIT option David Gibson
2017-07-11 16:13 ` [Qemu-devel] [PULL 00/17] ppc-for-2.10 queue 20170711 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711043917.1757-15-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=bharata@linux.vnet.ibm.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sbobroff@au1.ibm.com \
--cc=surajjs@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).