From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: agraf@suse.de, mdroth@linux.vnet.ibm.com, groug@kaod.org,
bharata@linux.vnet.ibm.com, lvivier@redhat.com, aik@ozlabs.ru,
surajjs@au1.ibm.com, sbobroff@au1.ibm.com, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 01/17] spapr: make spapr_populate_hotplug_cpu_dt() static
Date: Tue, 11 Jul 2017 14:39:01 +1000 [thread overview]
Message-ID: <20170711043917.1757-2-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20170711043917.1757-1-david@gibson.dropbear.id.au>
From: Greg Kurz <groug@kaod.org>
Since commit ff9006ddbfd1 ("spapr: move spapr_core_[foo]plug() callbacks
close to machine code in spapr.c"), this function doesn't need to be extern
anymore.
Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/spapr.c | 4 ++--
include/hw/ppc/spapr.h | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 0ee9fac..65d8ad2 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2863,8 +2863,8 @@ out:
error_propagate(errp, local_err);
}
-void *spapr_populate_hotplug_cpu_dt(CPUState *cs, int *fdt_offset,
- sPAPRMachineState *spapr)
+static void *spapr_populate_hotplug_cpu_dt(CPUState *cs, int *fdt_offset,
+ sPAPRMachineState *spapr)
{
PowerPCCPU *cpu = POWERPC_CPU(cs);
DeviceClass *dc = DEVICE_GET_CLASS(cs);
diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index a66bbac..12bf969 100644
--- a/include/hw/ppc/spapr.h
+++ b/include/hw/ppc/spapr.h
@@ -640,8 +640,6 @@ void spapr_hotplug_req_add_by_count_indexed(sPAPRDRConnectorType drc_type,
void spapr_hotplug_req_remove_by_count_indexed(sPAPRDRConnectorType drc_type,
uint32_t count, uint32_t index);
void spapr_cpu_parse_features(sPAPRMachineState *spapr);
-void *spapr_populate_hotplug_cpu_dt(CPUState *cs, int *fdt_offset,
- sPAPRMachineState *spapr);
/* CPU and LMB DRC release callbacks. */
void spapr_core_release(DeviceState *dev);
--
2.9.4
next prev parent reply other threads:[~2017-07-11 4:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 4:39 [Qemu-devel] [PULL 00/17] ppc-for-2.10 queue 20170711 David Gibson
2017-07-11 4:39 ` David Gibson [this message]
2017-07-11 4:39 ` [Qemu-devel] [PULL 02/17] spapr: refresh "platform-specific" hcalls comment David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 03/17] spapr: fix bogus function name in comment David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 04/17] spapr: fix migration to pseries machine < 2.8 David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 05/17] target-ppc: SPR_BOOKE_ESR not set on FP exceptions David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 06/17] spapr: Leave DR-indicator management to the guest David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 07/17] spapr: Uniform DRC reset paths David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 08/17] spapr: Add DRC release method David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 09/17] spapr: Remove unnecessary differences between hotplug and coldplug paths David Gibson
2017-07-12 8:26 ` Bharata B Rao
2017-07-12 9:29 ` Greg Kurz
2017-07-12 9:40 ` David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 10/17] spapr: Use unplug_request for PCI hot unplug David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 11/17] target/ppc: Refactor tcg radix mmu code David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 12/17] target/ppc: Add debug function for radix mmu translation David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 13/17] spapr: fix memory hotplug error path David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 14/17] spapr: Only report host/guest IOMMU page size mismatches on KVM David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 15/17] ppc/kvm: have the "family" CPU alias to point to TYPE_HOST_POWERPC_CPU David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 16/17] spapr: introduce the XIVE_EXPLOIT option in CAS David Gibson
2017-07-11 4:39 ` [Qemu-devel] [PULL 17/17] spapr: populate device tree depending on XIVE_EXPLOIT option David Gibson
2017-07-11 16:13 ` [Qemu-devel] [PULL 00/17] ppc-for-2.10 queue 20170711 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711043917.1757-2-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=bharata@linux.vnet.ibm.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sbobroff@au1.ibm.com \
--cc=surajjs@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).