Re: [Qemu-devel] [PATCH v3 05/10] pc-bios/s390-ccw: Move byteswap functions to a separate header

[Cornelia Huck <cohuck@redhat.com>]

On Tue, 11 Jul 2017 10:52:24 +0200
Thomas Huth <thuth@redhat.com> wrote:

> On 11.07.2017 09:59, Cornelia Huck wrote:
> > On Mon, 10 Jul 2017 17:32:35 +0200
> > Thomas Huth <thuth@redhat.com> wrote:
> >   
> >> We'll need them in code that is not related to bootmap.h, so
> >> they should reside in an independent header.
> >>
> >> Signed-off-by: Thomas Huth <thuth@redhat.com>
> >> ---
> >>  pc-bios/s390-ccw/bootmap.c |  1 +
> >>  pc-bios/s390-ccw/bootmap.h | 26 --------------------------
> >>  pc-bios/s390-ccw/bswap.h   | 25 +++++++++++++++++++++++++
> >>  3 files changed, 26 insertions(+), 26 deletions(-)
> >>  create mode 100644 pc-bios/s390-ccw/bswap.h  
> >   
> >> diff --git a/pc-bios/s390-ccw/bswap.h b/pc-bios/s390-ccw/bswap.h
> >> new file mode 100644
> >> index 0000000..45b5ef4
> >> --- /dev/null
> >> +++ b/pc-bios/s390-ccw/bswap.h  
> > 
> > Add a copyright/licence text?  
> 
> The original file include/qemu/bswap.h (where this code comes from) also
> does not have a copyright statement, so I was not sure which one to add
> here. I think that simply means that the default applies here...
> But I can certainly also add the default GPLv2+ statement if you think
> that we need it here...

No, that's fine; it's just the only file in this subdirectory without
an explicit header...

Acked-by: Cornelia Huck <cohuck@redhat.com>