From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUuPp-0002bf-60 for qemu-devel@nongnu.org; Tue, 11 Jul 2017 08:37:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUuPl-0002oe-DF for qemu-devel@nongnu.org; Tue, 11 Jul 2017 08:37:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52034) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dUuPl-0002oY-3r for qemu-devel@nongnu.org; Tue, 11 Jul 2017 08:37:17 -0400 Date: Tue, 11 Jul 2017 13:37:10 +0100 From: "Daniel P. Berrange" Message-ID: <20170711123710.GP7116@redhat.com> Reply-To: "Daniel P. Berrange" References: <1499773645-120137-1-git-send-email-peng.hao2@zte.com.cn> <20170711091506.GC7116@redhat.com> <4268aa00-6700-0554-10a2-451acb0baad6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4268aa00-6700-0554-10a2-451acb0baad6@redhat.com> Subject: Re: [Qemu-devel] [PATCH V2] chardev: fix parallel device can't be reconnect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peng Hao , marcandre.lureau@redhat.com, qemu-devel@nongnu.org, wang.yechao255@zte.com.cn On Tue, Jul 11, 2017 at 02:21:08PM +0200, Paolo Bonzini wrote: > On 11/07/2017 11:15, Daniel P. Berrange wrote: > > On Tue, Jul 11, 2017 at 10:30:14AM +0200, Paolo Bonzini wrote: > >> On 11/07/2017 13:47, Peng Hao wrote: > >>> Parallel device don't register be->chr_can_read function, but remote > >>> disconnect event is handled in chr_read.So connected parallel device > >>> can not detect remote disconnect event. The chardevs with chr_can_read=NULL > >>> has the same problem. > >>> > >>> Signed-off-by: Peng Hao > >>> Reviewed-by: Wang Yechao > >>> --- > >>> chardev/char-socket.c | 11 +++++++++++ > >>> chardev/char.c | 10 ++++++++++ > >>> include/chardev/char.h | 9 +++++++++ > >>> 3 files changed, 30 insertions(+) > >>> > >>> diff --git a/chardev/char-socket.c b/chardev/char-socket.c > >>> index ccc499c..aa44f8f 100644 > >>> --- a/chardev/char-socket.c > >>> +++ b/chardev/char-socket.c > >>> @@ -139,6 +139,9 @@ static int tcp_chr_read_poll(void *opaque) > >>> return 0; > >>> } > >>> s->max_size = qemu_chr_be_can_write(chr); > >>> + if (qemu_chr_null_be_can_read(chr)) { > >>> + return 1; > >>> + } > >>> return s->max_size; > >>> } > >>> > >>> @@ -422,6 +425,14 @@ static gboolean tcp_chr_read(QIOChannel *chan, GIOCondition cond, void *opaque) > >>> uint8_t buf[CHR_READ_BUF_LEN]; > >>> int len, size; > >>> > >>> + if (qemu_chr_null_be_can_read(chr)) { > >>> + size = tcp_chr_recv(chr, (void *)buf, CHR_READ_BUF_LEN); > >> > >> It would be better not to destroy data in the channel, because the > >> device could set handlers later. > >> > >> Daniel, maybe QIOChannel could have a function to check for hung-up > >> channels and return a bool? For file descriptors it would poll the file > >> descriptor and check for POLLHUP, while other channels would have a more > >> or less obvious implementation. > > > > IMHO the chardev code all needs to switch over to using even driven I/O > > using the qio_channel_add_watch() function. > > This is a slightly different case; qio_channel_add_watch() is for the > write side, while in this case we're concerned with the read side. > > The read-side watch is managed automatically by common chardev code. > I'll see if we can change that code to set up a G_IO_HUP watch in > addition to G_IO_IN. NB You don't ever need to use G_IO_HUP as an explicit input flag - poll() will always report G_IO_HUP if you asked it to monitor for G_IO_IN. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|