From: "Daniel P. Berrange" <berrange@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] Fix qemu-bridge-helper with SUID
Date: Tue, 11 Jul 2017 15:54:56 +0100 [thread overview]
Message-ID: <20170711145456.GT7116@redhat.com> (raw)
In-Reply-To: <03f93e78-b585-6d01-2c63-5de8dac97abe@redhat.com>
On Tue, Jul 11, 2017 at 03:10:43PM +0200, Michal Privoznik wrote:
> On 06/22/2017 05:58 PM, Michal Privoznik wrote:
> > On 05/30/2017 10:23 AM, Michal Privoznik wrote:
> >> For more description see patch 3. Long story short, if the bridge helper runs
> >> with SUID, the mechanism we rely on (DAC denying access to ACL files) does not
> >> work.
> >>
> >> Michal Privoznik (3):
> >> qemu-bridge-helper: Reverse return value setting logic
> >> qemu-bridge-helper: Reverse return value setting logic in
> >> parse_acl_file
> >> qemu-bridge-helper: Take ACL file gid into account
> >>
> >> qemu-bridge-helper.c | 79 ++++++++++++++++++++++++++++------------------------
> >> 1 file changed, 42 insertions(+), 37 deletions(-)
> >>
> >
> > ping?
> >
>
> ping^2?
Sigh, this is one of the files for which we have no nominated maintainer
listed, so it easily falls through the cracks.
Since this is network related, I wonder if Jason should be listed in the
MAINTAINERS file for this. Or perhaps we should move the qemu-bridge-helper.c
file into the net/ sub-directory instead ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-07-11 14:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 8:23 [Qemu-devel] [PATCH 0/3] Fix qemu-bridge-helper with SUID Michal Privoznik
2017-05-30 8:23 ` [Qemu-devel] [PATCH 1/3] qemu-bridge-helper: Reverse return value setting logic Michal Privoznik
2017-05-30 8:23 ` [Qemu-devel] [PATCH 2/3] qemu-bridge-helper: Reverse return value setting logic in parse_acl_file Michal Privoznik
2017-05-30 8:23 ` [Qemu-devel] [PATCH 3/3] qemu-bridge-helper: Take ACL file gid into account Michal Privoznik
2017-07-11 14:08 ` Daniel P. Berrange
2017-06-22 15:58 ` [Qemu-devel] [PATCH 0/3] Fix qemu-bridge-helper with SUID Michal Privoznik
2017-07-11 13:10 ` Michal Privoznik
2017-07-11 14:54 ` Daniel P. Berrange [this message]
2017-07-14 7:31 ` Jason Wang
2017-07-14 7:40 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711145456.GT7116@redhat.com \
--to=berrange@redhat.com \
--cc=jasowang@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).