From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dV2FC-0006jg-DR for qemu-devel@nongnu.org; Tue, 11 Jul 2017 16:58:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dV2F8-0003nf-IL for qemu-devel@nongnu.org; Tue, 11 Jul 2017 16:58:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38786) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dV2F8-0003nP-BZ for qemu-devel@nongnu.org; Tue, 11 Jul 2017 16:58:50 -0400 Date: Tue, 11 Jul 2017 17:58:42 -0300 From: Eduardo Habkost Message-ID: <20170711205842.GD6020@localhost.localdomain> References: <1499803333-9052-1-git-send-email-mark.cave-ayland@ilande.co.uk> <1499803333-9052-2-git-send-email-mark.cave-ayland@ilande.co.uk> <20170711201059.GA6020@localhost.localdomain> <20170711231709-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCHv8 1/3] fw_cfg: switch fw_cfg_find() to locate the fw_cfg device by type rather than path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Mark Cave-Ayland , "Michael S. Tsirkin" , QEMU Developers , Laszlo Ersek , "Gabriel L. Somlo" , Paolo Bonzini , "Richard W.M. Jones" , Igor Mammedov On Tue, Jul 11, 2017 at 09:49:30PM +0100, Peter Maydell wrote: > On 11 July 2017 at 21:26, Mark Cave-Ayland > wrote: > > On 11/07/17 21:18, Michael S. Tsirkin wrote: > > > >> Multi-line comments also should formatted > >> > >> /* > >> * like > >> * this > >> */ > >> > >> not > >> > >> /* like > >> * this */ > >> > > > > Interesting, I never knew there was a preferred format for comments (I > > see both styles throughout the codebase). > > It's basically GNU coding standard style vs Linux kernel style; > there's a mix because some contributors are more used to working > on the kernel, and some more used to working with gcc, glibc, > etc, and we haven't made a firm "comments must be like this" > statement (and of course historical practice in the codebase > is all over the place). > > We also have both of the flavours the kernel style guide > documents: > https://www.kernel.org/doc/html/v4.10/process/coding-style.html#commenting > (I usually use the style the kernel has for net/ personally.) > > So I don't think that "we" the project have a preferred > format; but "we" individual contributors probably > have individual preferences ;-) Thanks for the info. Please forget when I said I was going to send a CODING_STYLE patch for that. :) -- Eduardo