From: Stefan Hajnoczi <stefanha@redhat.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>
Cc: qemu-devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
Eric Blake <eblake@redhat.com>,
qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v4 4/4] block: add default implementations for bdrv_co_get_block_status()
Date: Wed, 12 Jul 2017 11:36:32 +0100 [thread overview]
Message-ID: <20170712103632.GG6923@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170711163748.17817-5-el13635@mail.ntua.gr>
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
On Tue, Jul 11, 2017 at 07:37:48PM +0300, Manos Pitsidianakis wrote:
> bdrv_co_get_block_status_from_file() and
> bdrv_co_get_block_status_from_backing() set *file to bs->file and
> bs->backing respectively, so that bdrv_co_get_block_status() can recurse
> to them. Future block drivers won't have to duplicate code to implement
> this.
>
> Reviewed-by: Fam Zheng <famz@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
> ---
> block/blkdebug.c | 12 +-----------
> block/commit.c | 12 +-----------
> block/io.c | 26 ++++++++++++++++++++++++++
> block/mirror.c | 12 +-----------
> include/block/block_int.h | 18 ++++++++++++++++++
> 5 files changed, 47 insertions(+), 33 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-07-12 10:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 16:37 [Qemu-devel] [PATCH v4 0/4] block: Block driver callbacks fixes Manos Pitsidianakis
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 1/4] block: pass bdrv_* methods to bs->file by default in block filters Manos Pitsidianakis
2017-07-11 17:02 ` Eric Blake
2017-07-12 10:34 ` Stefan Hajnoczi
2017-07-13 1:34 ` Eric Blake
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed Manos Pitsidianakis
2017-07-11 17:09 ` Eric Blake
2017-07-12 7:41 ` Markus Armbruster
2017-07-12 15:15 ` Kevin Wolf
2017-07-12 15:32 ` Manos Pitsidianakis
2017-07-12 10:35 ` Stefan Hajnoczi
2017-07-13 1:27 ` Eric Blake
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 3/4] block: remove bdrv_truncate callback in blkdebug Manos Pitsidianakis
2017-07-11 18:20 ` Eric Blake
2017-07-12 10:35 ` Stefan Hajnoczi
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 4/4] block: add default implementations for bdrv_co_get_block_status() Manos Pitsidianakis
2017-07-12 10:36 ` Stefan Hajnoczi [this message]
2017-07-12 7:49 ` [Qemu-devel] [PATCH v4 0/4] block: Block driver callbacks fixes Markus Armbruster
2017-07-12 8:10 ` Manos Pitsidianakis
2017-07-12 15:28 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712103632.GG6923@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).