From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVMrl-0004Vc-Ni for qemu-devel@nongnu.org; Wed, 12 Jul 2017 15:00:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVMrg-0007sr-TP for qemu-devel@nongnu.org; Wed, 12 Jul 2017 15:00:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47810) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dVMrg-0007sh-N4 for qemu-devel@nongnu.org; Wed, 12 Jul 2017 15:00:00 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5D1BF7DCC1 for ; Wed, 12 Jul 2017 18:59:59 +0000 (UTC) Date: Wed, 12 Jul 2017 19:59:53 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170712185952.GL30658@work-vm> References: <1499842423-21101-1-git-send-email-peterx@redhat.com> <1499842423-21101-4-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499842423-21101-4-git-send-email-peterx@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/3] migration: export capabilities to props List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Eduardo Habkost , Laurent Vivier , Markus Armbruster , Juan Quintela * Peter Xu (peterx@redhat.com) wrote: > Do the same thing to migration capabilities, just like what we did in > previous patch for migration parameters. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/migration/migration.c b/migration/migration.c > index fd00670..7e6f353 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -2001,6 +2001,9 @@ void migration_global_dump(Monitor *mon) > ms->send_configuration, ms->send_section_footer); > } > > +#define DEFINE_PROP_MIG_CAP(name, x) \ > + DEFINE_PROP_BOOL(name, MigrationState, enabled_capabilities[x], false) > + > static Property migration_properties[] = { > DEFINE_PROP_BOOL("store-global-state", MigrationState, > store_global_state, true), > @@ -2034,6 +2037,20 @@ static Property migration_properties[] = { > DEFINE_PROP_INT64("x-checkpoint-delay", MigrationState, > parameters.x_checkpoint_delay, > DEFAULT_MIGRATE_X_CHECKPOINT_DELAY), > + > + /* Migration capabilities */ > + DEFINE_PROP_MIG_CAP("xbzrle", MIGRATION_CAPABILITY_XBZRLE), > + DEFINE_PROP_MIG_CAP("rdma-pin-all", MIGRATION_CAPABILITY_RDMA_PIN_ALL), > + DEFINE_PROP_MIG_CAP("auto-converge", MIGRATION_CAPABILITY_AUTO_CONVERGE), > + DEFINE_PROP_MIG_CAP("zero-blocks", MIGRATION_CAPABILITY_ZERO_BLOCKS), > + DEFINE_PROP_MIG_CAP("compress", MIGRATION_CAPABILITY_COMPRESS), > + DEFINE_PROP_MIG_CAP("events", MIGRATION_CAPABILITY_EVENTS), > + DEFINE_PROP_MIG_CAP("postcopy-ram", MIGRATION_CAPABILITY_POSTCOPY_RAM), > + DEFINE_PROP_MIG_CAP("x-colo", MIGRATION_CAPABILITY_X_COLO), > + DEFINE_PROP_MIG_CAP("release-ram", MIGRATION_CAPABILITY_RELEASE_RAM), > + DEFINE_PROP_MIG_CAP("block", MIGRATION_CAPABILITY_BLOCK), > + DEFINE_PROP_MIG_CAP("return-path", MIGRATION_CAPABILITY_RETURN_PATH), > + > DEFINE_PROP_END_OF_LIST(), > }; > > -- > 2.7.4 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK