From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVNC4-0004P5-UL for qemu-devel@nongnu.org; Wed, 12 Jul 2017 15:21:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVNC0-0004RO-VD for qemu-devel@nongnu.org; Wed, 12 Jul 2017 15:21:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49866) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dVNC0-0004Qq-Pm for qemu-devel@nongnu.org; Wed, 12 Jul 2017 15:21:00 -0400 Date: Wed, 12 Jul 2017 16:20:55 -0300 From: Eduardo Habkost Message-ID: <20170712192055.GL6020@localhost.localdomain> References: <20170711004303.3902-1-ehabkost@redhat.com> <20170711004303.3902-4-ehabkost@redhat.com> <2cda5b0b-0169-d12e-114e-77fcb1a4bb07@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2cda5b0b-0169-d12e-114e-77fcb1a4bb07@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 3/3] Revert "machine: Convert abstract typename on compat_props to subclass names" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: qemu-devel@nongnu.org, Marcel Apfelbaum , Cornelia Huck , Greg Kurz On Wed, Jul 12, 2017 at 07:49:22PM +0200, Halil Pasic wrote: > On 07/11/2017 02:43 AM, Eduardo Habkost wrote: > > This reverts commit 0bcba41fe379e4c6834adcf1456d9099db31a5b2. > > > > The bug addressed by that commit is now fixed in a better way by the > > commit "qdev: fix the order compat and global properties are applied". > > > > Signed-off-by: Eduardo Habkost > > Reviewed-by: Halil Pasic > > Note: It is not like the effect of commit 0bcba41fe3 is canceled > out with your first patch in place. It depends on the client > code (the implementation of the individual devices) wether > this patch changes something or not. I did not check myself. > So the did you verify that nothing breaks with this change applies > here too. I don't get this part. I don't see how individual devices implementation will be able to affect the outcome after this patch is applied. GlobalProperty::driver is not used as input for object_property_parse() at all (see qdev_prop_set_globals()). This means exactly the same property setter is invoked when registering "." or ".". The only difference introduced by this series is in the ordering of the object_property_parse() calls. And even the object_property_parse() call ordering is not affected by this patch at all, because of patch 1/3. Patch 1/3 will ensure the properties will be applied in exactly the same order they were registered, so this patch should introduce absolutely no behavior change on any device. -- Eduardo