From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>,
Richard Henderson <rth@twiddle.net>,
Fei Li <sherrylf@linux.vnet.ibm.com>,
Yi Min Zhao <zyimin@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 08/11] s390x/flic: introduce modify_ais_mode callback
Date: Thu, 13 Jul 2017 09:27:53 +0200 [thread overview]
Message-ID: <20170713092753.5a3ba530@gondolin> (raw)
In-Reply-To: <e44ca276-3318-1a18-9075-8edd6305c69c@de.ibm.com>
On Thu, 13 Jul 2017 09:12:50 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> On 07/12/2017 05:07 PM, Cornelia Huck wrote:
> >> +
> >> + switch (mode) {
> >> + case SIC_IRQ_MODE_ALL:
> >> + flic->simm &= ~AIS_MODE_MASK(isc);
> >> + flic->nimm &= ~AIS_MODE_MASK(isc);
> >> + break;
> >> + case SIC_IRQ_MODE_SINGLE:
> >> + flic->simm |= AIS_MODE_MASK(isc);
> >> + flic->nimm &= ~AIS_MODE_MASK(isc);
> >
> > Can we have some documentation about the meaning of simm/nimm in qemu?
> > The one from the patch description of the respective kernel patch would
> > be fine.
>
> Do you want to have that description as part of the patch description or
> somewhere in the docs folder or somewhere in the code?
A comment near the definition of simm/nimm would be nice. Or in the
commit message, as for the kernel.
next prev parent reply other threads:[~2017-07-13 7:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 12:57 [Qemu-devel] [PATCH 00/11] pending s390 patches part 1 Christian Borntraeger
2017-07-12 12:57 ` [Qemu-devel] [PATCH 01/11] s390x/kvm: Rework cmma management Christian Borntraeger
2017-07-12 13:49 ` Cornelia Huck
2017-07-13 5:37 ` Janosch Frank
2017-07-12 12:57 ` [Qemu-devel] [PATCH 02/11] linux-headers: update to 4.13-rc0 Christian Borntraeger
2017-07-12 12:57 ` [Qemu-devel] [PATCH 03/11] s390x/migration: Storage attributes device Christian Borntraeger
2017-07-12 14:09 ` Thomas Huth
2017-07-13 7:11 ` Christian Borntraeger
2017-07-13 7:32 ` Cornelia Huck
2017-07-13 7:35 ` Thomas Huth
2017-07-13 7:45 ` Christian Borntraeger
2017-07-12 12:57 ` [Qemu-devel] [PATCH 04/11] s390x/migration: Monitor commands for storage attributes Christian Borntraeger
2017-07-12 12:57 ` [Qemu-devel] [PATCH 05/11] s390x/cpumodel: clean up spacing and comments Christian Borntraeger
2017-07-12 12:57 ` [Qemu-devel] [PATCH 06/11] s390x/cpumodel: provide compat handling for new cpu features Christian Borntraeger
2017-07-12 14:51 ` Cornelia Huck
2017-07-12 12:57 ` [Qemu-devel] [PATCH 07/11] s390x: add flags field for registering I/O adapter Christian Borntraeger
2017-07-12 15:00 ` Cornelia Huck
2017-07-12 12:57 ` [Qemu-devel] [PATCH 08/11] s390x/flic: introduce modify_ais_mode callback Christian Borntraeger
2017-07-12 15:07 ` Cornelia Huck
2017-07-13 7:12 ` Christian Borntraeger
2017-07-13 7:27 ` Cornelia Huck [this message]
2017-07-13 7:35 ` Christian Borntraeger
2017-07-13 7:47 ` Cornelia Huck
2017-07-12 12:57 ` [Qemu-devel] [PATCH 09/11] s390x/flic: introduce inject_airq callback Christian Borntraeger
2017-07-12 15:12 ` Cornelia Huck
2017-07-12 12:57 ` [Qemu-devel] [PATCH 10/11] s390x/sic: realize SIC handling Christian Borntraeger
2017-07-12 13:40 ` Thomas Huth
2017-07-12 15:40 ` Cornelia Huck
2017-07-12 12:57 ` [Qemu-devel] [PATCH 11/11] s390x/css: update css_adapter_interrupt Christian Borntraeger
2017-07-12 14:26 ` Thomas Huth
2017-07-13 8:08 ` Christian Borntraeger
2017-07-13 8:18 ` Thomas Huth
2017-07-13 8:46 ` Cornelia Huck
2017-07-12 13:31 ` [Qemu-devel] [PATCH 00/11] pending s390 patches part 1 Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713092753.5a3ba530@gondolin \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sherrylf@linux.vnet.ibm.com \
--cc=zyimin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).