qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Tomáš Golembiovský" <tgolembi@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC 0/3] qemu-ga: support for sending events
Date: Thu, 13 Jul 2017 10:51:11 +0200	[thread overview]
Message-ID: <20170713105111.4f26e435@fiorina> (raw)
In-Reply-To: <346b5b87-4d9b-ab82-8966-71680ae06af0@redhat.com>

On Fri, 7 Jul 2017 15:55:31 -0500
Eric Blake <eblake@redhat.com> wrote:

> On 06/23/2017 08:02 AM, Tomáš Golembiovský wrote:
> > This is just a draft, or a request for comments if you will.
> > 
> > This patch sets drafts the support of sending events by QEMU Guest Agent.
> > Events can plan important role in monitoring of the guest OS behaviour. The
> > range of use cases ranges from events important for scheduling, e.g. memory and
> > CPU usage statistics, to things like changes to IP addresses on network
> > interfaces to for example changes in the list of active users.
> > 
> > For now the patch set adds single periodic callback function to the GA main
> > loop that can perform checks and trigger events that have occured since
> > previous run of the callback.  
> 
> How do we guarantee that the guest cannot flood qemu with too many events?
> 
> Obviously, qga is already used where we (in general) trust the guest to
> not be malicious, but we still have to assume that a guest can be
> compromised, and will try to abuse qga to escape to an attack against qemu.
> 

If you mean situation where something in guest will be triggering events
that qga will be sending then we can implement some throttling in qga. I
belive qemu does something similar for QMP events.

But if you're considering situation where something kills qga and will
attach itself to the serial channel then this is of course more
complex issue.

> > 
> > We can of course take it one step further and add a general framwork for
> > periodically running any of the already implemented commands. Add a function
> > that would maintain a list of registered checks. Client would use some command
> > (register-monitor-command) passing it a command name and timeout in seconds and
> > the monitoring handler would then run the specified command and report the
> > result... or report only if the return value changed since previous invocation.
> > This feature would remove part of the communication overhead between client and
> > GA.
> > 
> > So before I invest any more time in either of these approaches, tell me. Would
> > somethign like this be wanted or is that too controversial? Any other thoughts
> > and ideas?
> >   
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
> 


-- 
Tomáš Golembiovský <tgolembi@redhat.com>

      reply	other threads:[~2017-07-13  8:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 13:02 [Qemu-devel] [RFC 0/3] qemu-ga: support for sending events Tomáš Golembiovský
2017-06-23 13:02 ` [Qemu-devel] [RFC 1/3] qemu-ga: add support for events Tomáš Golembiovský
2017-07-07 20:53   ` Eric Blake
2017-07-13  8:56     ` Tomáš Golembiovský
2017-06-23 13:02 ` [Qemu-devel] [RFC 2/3] qemu-ga: add simple event reporting memory statistics Tomáš Golembiovský
2017-06-23 13:02 ` [Qemu-devel] [RFC 3/3] qemu-ga: add support for periodic command runner Tomáš Golembiovský
2017-06-23 13:25 ` [Qemu-devel] [RFC 0/3] qemu-ga: support for sending events Marc-André Lureau
2017-06-25 21:25   ` Tomáš Golembiovský
2017-07-07 20:48     ` Tomáš Golembiovský
2017-07-07 20:55 ` Eric Blake
2017-07-13  8:51   ` Tomáš Golembiovský [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170713105111.4f26e435@fiorina \
    --to=tgolembi@redhat.com \
    --cc=eblake@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).