From: Ladi Prosek <lprosek@redhat.com>
To: qemu-devel@nongnu.org
Cc: casasfernando@hotmail.com, mst@redhat.com, jasowang@redhat.com,
armbru@redhat.com, groug@kaod.org, arei.gonglei@huawei.com,
aneesh.kumar@linux.vnet.ibm.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/8] virtio: enhance virtio_error messages
Date: Thu, 13 Jul 2017 13:02:29 +0200 [thread overview]
Message-ID: <20170713110237.6712-1-lprosek@redhat.com> (raw)
Output like "Virtqueue size exceeded" is not much useful in identifying the
culprit. This series beefs up virtio_error to print the virtio device name
and id, and introduces virtqueue_error which additionally includes the index
of the virtqueue where the error occured.
Patches 1 to 3 lay the groundwork, patches 4 to 8 convert virtio devices to
use virtqueue_error instead of virtio_error.
v1->v2:
* Modified virtio_error and added virtqueue_error (Stefan)
* Now also printing device id (Stefan)
* Went over all virtio_error call sites and converted them to virtqueue_error
as appropriate; added virtio device maintainers to cc
Ladi Prosek (8):
qemu-error: introduce error_report_nolf
virtio: enhance virtio_error messages
virtio: introduce virtqueue_error
virtio-9p: use virtqueue_error for errors with queue context
virtio-blk: use virtqueue_error for errors with queue context
virtio-net: use virtqueue_error for errors with queue context
virtio-scsi: use virtqueue_error for errors with queue context
virtio-crypto: use virtqueue_error for errors with queue context
hw/9pfs/virtio-9p-device.c | 37 ++++++--------
hw/block/virtio-blk.c | 6 +--
hw/net/virtio-net.c | 24 ++++-----
hw/scsi/virtio-scsi.c | 2 +-
hw/virtio/virtio-crypto.c | 56 ++++++++++-----------
hw/virtio/virtio.c | 116 ++++++++++++++++++++++++++++++--------------
include/hw/virtio/virtio.h | 1 +
include/qemu/error-report.h | 3 +-
util/qemu-error.c | 32 +++++++++---
9 files changed, 169 insertions(+), 108 deletions(-)
--
2.9.3
next reply other threads:[~2017-07-13 11:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 11:02 Ladi Prosek [this message]
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf Ladi Prosek
2017-07-13 13:32 ` Stefan Hajnoczi
2017-07-13 13:48 ` Ladi Prosek
2017-07-14 10:25 ` Stefan Hajnoczi
2017-07-15 5:50 ` Markus Armbruster
2017-07-17 6:43 ` Ladi Prosek
2017-07-14 10:41 ` Daniel P. Berrange
2017-07-17 6:54 ` Ladi Prosek
2017-07-17 8:58 ` Daniel P. Berrange
2017-07-17 9:30 ` Ladi Prosek
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 2/8] virtio: enhance virtio_error messages Ladi Prosek
2017-07-13 13:40 ` Stefan Hajnoczi
2017-07-13 13:58 ` Ladi Prosek
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 3/8] virtio: introduce virtqueue_error Ladi Prosek
2017-07-13 14:42 ` Cornelia Huck
2017-07-13 15:02 ` Ladi Prosek
2017-07-14 10:28 ` Stefan Hajnoczi
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 4/8] virtio-9p: use virtqueue_error for errors with queue context Ladi Prosek
2017-07-13 14:21 ` Greg Kurz
2017-07-13 14:49 ` Cornelia Huck
2017-07-14 10:29 ` Stefan Hajnoczi
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 5/8] virtio-blk: " Ladi Prosek
2017-07-13 14:54 ` Cornelia Huck
2017-07-14 10:29 ` Stefan Hajnoczi
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 6/8] virtio-net: " Ladi Prosek
2017-07-13 15:00 ` Cornelia Huck
2017-07-14 10:30 ` Stefan Hajnoczi
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 7/8] virtio-scsi: " Ladi Prosek
2017-07-13 15:03 ` Cornelia Huck
2017-07-14 10:30 ` Stefan Hajnoczi
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 8/8] virtio-crypto: " Ladi Prosek
2017-07-13 15:20 ` Cornelia Huck
2017-07-13 15:31 ` Ladi Prosek
2017-07-13 15:36 ` Cornelia Huck
2017-07-14 0:51 ` Gonglei (Arei)
2017-07-14 10:31 ` Stefan Hajnoczi
2017-07-13 14:36 ` [Qemu-devel] [PATCH v2 0/8] virtio: enhance virtio_error messages Greg Kurz
2017-07-13 15:00 ` Ladi Prosek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713110237.6712-1-lprosek@redhat.com \
--to=lprosek@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=casasfernando@hotmail.com \
--cc=groug@kaod.org \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).