From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, lvivier@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/5] migration: Close file on failed migration load
Date: Fri, 14 Jul 2017 11:27:53 +0800 [thread overview]
Message-ID: <20170714032753.GF27284@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170713115649.11853-3-dgilbert@redhat.com>
On Thu, Jul 13, 2017 at 12:56:46PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Closing the file before exit on a failure allows
> the source to cleanup better, especially with RDMA.
>
> Partial fix for https://bugs.launchpad.net/qemu/+bug/1545052
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2017-07-14 3:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 11:56 [Qemu-devel] [PATCH v2 0/5] A bunch of RDMA fixes Dr. David Alan Gilbert (git)
2017-07-13 11:56 ` [Qemu-devel] [PATCH v2 1/5] migration/rdma: Fix race on source Dr. David Alan Gilbert (git)
2017-07-13 11:56 ` [Qemu-devel] [PATCH v2 2/5] migration: Close file on failed migration load Dr. David Alan Gilbert (git)
2017-07-14 3:27 ` Peter Xu [this message]
2017-07-13 11:56 ` [Qemu-devel] [PATCH v2 3/5] migration/rdma: Allow cancelling while waiting for wrid Dr. David Alan Gilbert (git)
2017-07-14 3:36 ` Peter Xu
2017-07-14 11:13 ` Dr. David Alan Gilbert
2017-07-13 11:56 ` [Qemu-devel] [PATCH v2 4/5] migration/rdma: Safely convert control types Dr. David Alan Gilbert (git)
2017-07-13 11:56 ` [Qemu-devel] [PATCH v2 5/5] migration/rdma: Send error during cancelling Dr. David Alan Gilbert (git)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714032753.GF27284@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).